Add unit tests #42
Merged
Add unit tests #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
streeve
force-pushed
the
unit_test
branch
2 times, most recently
from
c7c62e0 to
7807193
Compare
|
Updated this to add only integration test (wait on neighbor tests until those PRs are done) - this is ready for review |
sslattery
requested changes
Apr 6, 2020
unit_test/CMakeLists.txt
Outdated
| set(_target ${_test}_test_${_uppercase_device}) | ||
| add_executable(${_target} ${_file} ${CABANAMD_UNIT_TEST_MAIN}) | ||
| target_include_directories(${_target} PRIVATE ${_dir} ${CMAKE_CURRENT_SOURCE_DIR}) | ||
| target_link_libraries(${_target} PRIVATE CabanaMD gtest Cabana::cabanacore Kokkos::kokkos MPI::MPI_CXX) |
There was a problem hiding this comment.
Do you have your own CabanaMD target you can link instead? You would likely just need to link that single target instead of the list of targets here.
unit_test/TestTHREADS_Category.hpp
Outdated
| #ifndef CABANA_TEST_PTHREAD_CATEGORY_HPP | ||
| #define CABANA_TEST_PTHREAD_CATEGORY_HPP | ||
|
|
||
| #define TEST_CATEGORY pthread |
There was a problem hiding this comment.
You don't have a Threads device type listed in your CMakeLists.txt for the unit tests so you probably don't need this file. We haven't been testing against pthreads as everything seems to have moved to OpenMP.
junghans
reviewed
Apr 9, 2020
sslattery
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple integrator test, with most of the other code copied from Cabana.
The intent is to add tests for at least each of the main classes - this is the first step for #44