-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 6D minimum and maximum values to reduced beam characteristics #474
Add 6D minimum and maximum values to reduced beam characteristics #474
Conversation
Added 6D minimum and maximum values for the beam to output of reduced beam characteristics.
Added documentation for the min/max values to the documentation and added unit information where it was missing for the reduced_beam_characteristics function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
The reduction over all particles is now merged with the existing one for the mean values. This avoids that we have to iterate over all particles an additional time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for this, @n01r ✨
This PR adds global minimum and maximum values for all phase space coordinates
x
,y
,t
,px
,py
,pt
of the particle beam to theReducedBeamCharacteristics
output.Documentation for quantities is added and unit information for the
reduced_beam_characteristics()
function has been added where it was missing.See below visualizations of output from the FODO example