Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 6D minimum and maximum values to reduced beam characteristics #474

Merged

Conversation

n01r
Copy link
Member

@n01r n01r commented Nov 29, 2023

This PR adds global minimum and maximum values for all phase space coordinates x, y, t, px, py, pt of the particle beam to the ReducedBeamCharacteristics output.

Documentation for quantities is added and unit information for the reduced_beam_characteristics() function has been added where it was missing.

See below visualizations of output from the FODO example

x y t
x_min_max y_min_max t_min_max
px py pt
px_min_max py_min_max pt_min_max

n01r added 2 commits November 28, 2023 17:03
Added 6D minimum and maximum values for the beam to output
of reduced beam characteristics.
Added documentation for the min/max values to the documentation and
added unit information where it was missing for the
reduced_beam_characteristics function.
@n01r n01r requested review from ax3l and cemitch99 November 29, 2023 20:10
@n01r n01r added component: documentation Docs, readme and manual component: diagnostics all types of outputs labels Nov 29, 2023
@n01r n01r requested a review from RTSandberg November 29, 2023 20:11
Copy link
Member

@RTSandberg RTSandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ax3l ax3l self-assigned this Nov 30, 2023
The reduction over all particles is now merged with the existing one
for the mean values. This avoids that we have to iterate over all
particles an additional time.
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for this, @n01r

@ax3l ax3l merged commit 4a78861 into ECP-WarpX:development Dec 1, 2023
13 checks passed
@n01r n01r deleted the topic-add6DMinMaxToReducedBeamCharacteristics branch December 1, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics all types of outputs component: documentation Docs, readme and manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants