Added an s-dependent IOTA lens example #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the initial beam size in the IOTA lens benchmark example. - Added 2 benchmarks of 3D space charge for initial testing. - Add documentation for 2 benchmarks with space charge. - Add a benchmark example with space charge and periodic s-dependent focusing. - Added an s-dependent example using a Kurth beam without space charge. - Modified tolerance for IOTA lens benchmark example. Reduced tolerance to account for smaller initial beam size and improved preservation of invariants of motion. - Modified tolerances of space charge examples to allow CI tests to pass when space charge is not active. - Modified tolerance for space charge examples. These should fail unless space charge is turned on.
Selected numerical values for amr.n_cell, lattice.nslice, and geometry.prob_relative.
Not part of this PR.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Modified lattice to place nonlinear lens (nll) as the first element.
Modified initial beam moments for matching
RTSandberg
reviewed
Nov 28, 2023
Co-authored-by: Ryan Sandberg <[email protected]>
Added initial x-px and y-py correlations.
for more information, see https://pre-commit.ci
cemitch99
commented
Nov 29, 2023
| amrex::ParticleReal const pxn = px*sqrt(m_beta)/m_cn + m_alpha*x; | ||
| amrex::ParticleReal const pyn = py*sqrt(m_beta)/m_cn + m_alpha*y; | ||
| amrex::ParticleReal const pxn = px*sqrt(m_beta)/m_cn + m_alpha*xn; | ||
| amrex::ParticleReal const pyn = py*sqrt(m_beta)/m_cn + m_alpha*yn; | ||
|
|
There was a problem hiding this comment.
Fixed a typo here. This only affects the diagnostics when alpha is nonzero.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Relax tolerance for (H,I) moments.
Relax tolerance of (dH,dI) slightly.
Comment Python-based tests until Python bindings for NL invariants are updated.
Relaxing the tolerance of dI slightly.
Tune target statistics for (H,I) slightly.
for more information, see https://pre-commit.ci
Turn on Python run tests, without analysis.
Use dummy analysis scripts for Python testing.
Fix location of analysis file.
Increase tolerance.
Relax tolerance in dummy script.
for more information, see https://pre-commit.ci
Tighten tolerance for Python tests (lens).
Tighten tolerance Python test (lattice).
Eliminate unnecessary dummy analysis scripts.
Remove unnecessary dummy analysis scripts.
Remove unnecessary dummy analysis scriipts.
for more information, see https://pre-commit.ci
Pin down slight differences in initial beam generation in app vs. Python script.
Tighten tolerance again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a segmented IOTA lens example (Python) using 18 segments with the full s-dependence of the focusing.
The number of segments can be adjusted as a parameter.
The diagnostic output for the nonlinear invariants (H,I) needs to be updated to the corresponding values of alpha, beta, etc. This requires that Python bindings be added for these parameters.
Tasks