Dist None: Set to Zero #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With GCC 12, compiling the `None` distribution throws warnings in compilation of `add_particles`. Originally, this was added so that the `std::variant` for `impactx::distribution::KnownDistributions` creates a default constructor for the variant. Adding an assert that the distribution cannot be used in `add_particles` does not silence the warning diagnostics. Thus, we simply make it a distribution that sets the values to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GCC 12, compiling the
Nonedistribution throws warnings in compilation ofadd_particles. Originally, this was added so that thestd::variantforimpactx::distribution::KnownDistributionscreates a default constructor for the variant.Adding an assert that the distribution cannot be used in
add_particlesdoes not silence the warning diagnostics. Thus, we simply make it a distribution that sets the values to zero.