-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Test checksums with new EB structures #5574
base: development
Are you sure you want to change the base?
Conversation
…to move_stair_case_approx
This reverts commit 4fd4dc7.
Thanks for going through the effort to run this test! It is interesting that the failing test
The updated checksum values in the PR with the moved staircase:
|
72d2e26
to
a6eba80
Compare
a6eba80
to
4b4e761
Compare
@roelof-groenewald Yes, I think I found the reason for this and fixed it in this commit: The reason is that, with the ECT solver, |
Cool! It is awesome that all the CI tests pass now without any checksum value changes. Seeing as you went through the work for this PR, we could merge this one as a purely code-cleaning PR, and then have #5534 be the PR that specifically changes the way the staircase-approximation is done. What do you think? |
No description provided.