-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: CDash dashboard support #5566
base: development
Are you sure you want to change the base?
Conversation
So far, just adding But... what if we want to get into the
Still, does not submit and
does not push it out... |
I managed to get some better AI assistance and here's some useful information (to be double checked, of course):
Why using
Why using
|
.azure-pipelines.yml
Outdated
# determine if the build was triggered by a push to the development branch | ||
if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then | ||
# run tests (exclude pytest.AMReX when running Python tests) | ||
# and submit results to CDash as Continuous | ||
ctest --test-dir build --output-on-failure -E AMReX -D Continuous | ||
else | ||
# run tests (exclude pytest.AMReX when running Python tests) | ||
ctest --test-dir build --output-on-failure -E AMReX | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I would try first, based on the information reported in #5566 (comment).
Update
This is probably duplicating the configure and build step. Looking more into how to avoid duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again on this, and on the issues reported in #5566 (comment), reading the documentation more carefully it seems to me that the various "steps" (e.g., Start
, Update
, Configure
, Build
, Test
, MemoryCheck
, Coverage
, Submit
) can be run independently only for the Nightly
or Experimental
modes, but not for the other modes such as Continuous
. This could explain what we observed so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuous
still seems like the right choice for main branch events, such as merging PRs into the main branch, from a theoretical point of view. But, as discussed, we could start with Experimental
and fine tune things later on, once we have gained more experience with CDash overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# determine if the build was triggered by a push to the development branch | |
if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then | |
# run tests (exclude pytest.AMReX when running Python tests) | |
# and submit results to CDash as Continuous | |
ctest --test-dir build --output-on-failure -E AMReX -D Continuous | |
else | |
# run tests (exclude pytest.AMReX when running Python tests) | |
ctest --test-dir build --output-on-failure -E AMReX | |
fi | |
# determine if the build was triggered by a push to the development branch | |
if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then | |
# run tests (exclude pytest.AMReX when running Python tests) | |
# and submit results to CDash as Experimental | |
ctest --test-dir build --output-on-failure -E AMReX \ | |
-D ExperimentalTest -D ExperimentalSubmit | |
else | |
# run tests (exclude pytest.AMReX when running Python tests) | |
ctest --test-dir build --output-on-failure -E AMReX | |
fi |
# Additional settings | ||
set(CTEST_SITE "Azure-Pipelines") | ||
set(CTEST_BUILD_NAME "CI-Development") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# run tests (exclude pytest.AMReX when running Python tests) | ||
ctest --test-dir build --output-on-failure -E AMReX | ||
# determine if the build was triggered by a push to the development branch | ||
if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this does not work (but we'll know only after merging the PR into development
), we can also try the following (see https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables for more documentation):
if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then | |
if [[ "$(Build.Reason)" == "IndividualCI" ]]; then |
Trying to add and set up CDash dashboard support for WarpX. Close #5292.
Relevant documentation: