[WIP] Add automated test for particle absorption on new stair-case approximation #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to move_stair_case_approx
This reverts commit 4fd4dc7.
RemiLehe
force-pushed
the
eb_absorption_test
branch
from
c9ead4d to
df82ace
Compare
RemiLehe
changed the title
RemiLehe
force-pushed
the
eb_absorption_test
branch
from
bb9b4df to
0bba7c9
Compare
Add file for checksum tests Update comment
RemiLehe
force-pushed
the
eb_absorption_test
branch
from
0bba7c9 to
069a63e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge #5534 first.
This introduces automated tests in 2D, 3D and RZ to check that a particle does not leave a spurious charge behind, when absorbed by the embedded boundary, and when using an EM solver.
In this test, the embedded boundary is a cylinder aligned with the z axis. (In 2D, this reduces to two parallel plates.)
The tests fail on the
developmentbranch, before #5534 is merged. They pass after #5534 is merged.developmentbranch, before Modify stair-case approximation to the EB #5534 is merged:Note that these tests fails for higher-order shapes. This will be fixed in #5209