Pass gamma_boost as an argument to AcceleratorLattice and LatticeElementFinder #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entFinder, instead of using WarpX::gamma_boost
EZoni
reviewed
Jan 9, 2025
EZoni
reviewed
Jan 9, 2025
EZoni
reviewed
Jan 9, 2025
Source/WarpX.cpp
Outdated
There was a problem hiding this comment.
What is the reason why we cannot yet redefine gamma_boost as private in WarpX.H?
//! Lorentz factor of the boosted frame in which a boosted-frame simulation is run
static amrex::Real gamma_boost;
EZoni
requested changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small step towards the goal of reducing the usage of static variables in the WarpX class.