-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restart for implicit simulations #5489
Conversation
As a bonus, the parallel communication is also turned off
Hi @JustinRayAngus - just checking, did you get a chance to verify that this fixes the issue for you? |
Shall we merge |
I can do the merge of development. I've checked the changes in this PR and it works. |
|
||
pc->Checkpoint(dir, part_diag.getSpeciesName(), true, | ||
pc->Checkpoint(dir, part_diag.getSpeciesName(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinRayAngus is experiencing a build issue from this call right now. @dpgrote is taking a look.
Fix #5482.
Also, with this PR the temporary implicit particle attributes are not written to the checkpoint file, and also are not communicated when doing a redistribute of the particles. Note that this requires AMReX PR #4264.
A CI test of this restart is included in PR #5475.