Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restart for implicit simulations #5489

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Dec 2, 2024

Fix #5482.

Also, with this PR the temporary implicit particle attributes are not written to the checkpoint file, and also are not communicated when doing a redistribute of the particles. Note that this requires AMReX PR #4264.

A CI test of this restart is included in PR #5475.

As a bonus, the parallel communication is also turned off
@atmyers
Copy link
Member Author

atmyers commented Jan 13, 2025

Hi @JustinRayAngus - just checking, did you get a chance to verify that this fixes the issue for you?

@EZoni EZoni requested a review from dpgrote January 15, 2025 00:13
@EZoni EZoni added bug Something isn't working bug: affects latest release Bug also exists in latest release version labels Jan 15, 2025
@EZoni
Copy link
Member

EZoni commented Jan 17, 2025

@atmyers

Shall we merge development to re-run the CI checks and then just merge this? If the CI checks pass, I guess we could fix possible residual bugs in a follow-up PR. What do you think?

@dpgrote
Copy link
Member

dpgrote commented Jan 17, 2025

@atmyers

Shall we merge development to re-run the CI checks and then just merge this? If the CI checks pass, I guess we could fix possible residual bugs in a follow-up PR. What do you think?

I can do the merge of development. I've checked the changes in this PR and it works.

@EZoni EZoni enabled auto-merge (squash) January 17, 2025 17:43
@EZoni EZoni merged commit e4bdcae into ECP-WarpX:development Jan 17, 2025
37 checks passed

pc->Checkpoint(dir, part_diag.getSpeciesName(), true,
pc->Checkpoint(dir, part_diag.getSpeciesName(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinRayAngus is experiencing a build issue from this call right now. @dpgrote is taking a look.

@ax3l ax3l added component: checkpoint/restart Checkpointing & restarts component: implicit solvers Anything related to implicit solvers labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: checkpoint/restart Checkpointing & restarts component: implicit solvers Anything related to implicit solvers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restart with implicit solver
6 participants