-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: useful error when initialize_warpx
not called before creating ParticleContainerWrapper
#5412
Merged
Merged
Python: useful error when initialize_warpx
not called before creating ParticleContainerWrapper
#5412
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5050f2d
add useful error message when user forgets to call initialize_warpx i…
archermarx 9023112
change wording
archermarx 65fd8e9
Merge branch 'ECP-WarpX:development' into libwarpx-error
archermarx ea11dce
Lazy initialize particle container and boundary buffer
archermarx 1ade374
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0e41a4d
fix boundary buffer error message
archermarx c197935
Merge branch 'libwarpx-error' of github.com:archermarx/WarpX into lib…
archermarx 3436de6
use @property instead of getter
archermarx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! Sorry for just seeing it now, I was just on parental leave when the PR was opened.
I thought we could also add one more fallback, right in the library loader, where we assign the
libwarpx.warpx
attribute.In essence, we could assign an initial attribute that throws when accessed with a more distinct error message ("initialize_warpx was not yet called!"), to catch all. More specific exceptions like this one are great to add and keep.
One initialization, we then just overwrite the attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh neat idea! I can open a new PR shortly!