Dev hp main deployment #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change look good to me too. Can you elaborate on the reason for the change in the description of the PR, for documentation purposes. |
jhanavigera
reviewed
Nov 14, 2023
| @@ -11,29 +11,29 @@ services: | |||
| - "5000:5000" | |||
| environment: | |||
| - FLASK_APP=app/main.py | |||
| - ELASTICSEARCH_HOST=elasticsearch | |||
| depends_on: | |||
| - elasticsearch | |||
There was a problem hiding this comment.
If we are removing elastic search then we don't necessarily need this file because we can run the flask app using the Dockerfile
There was a problem hiding this comment.
I agree, the change was made to alter the GitHub workflow
jhanavigera
approved these changes
Nov 14, 2023
|
Closing the pull request - @kb21032001 branch ( #174) has built upon my changes and will be merged instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for replacing elastic search with a simple search for easier deployment.
We were facing resource constraints when deploying with elastic search on the free tier of the Amazon EC2 instance hence we have decided to re-route the search to a simpler in-house implementation which consumes less ram and processor speed.
Here is an image showing resource utilization when running elastic search on EC2 instance
