Allow patches to be reused in plot_horiz_field()

[xylar]

This merge returns patches and patch_mask variables from plot_horiz_field() so they can be reused in subsequent calls. This should save a lot of time in tests that plot many fields. Corresponding input arguments have been added to take patches and patch_mask from previous plots on the same mesh.

Note: you need need to keep patches for cells and edges separate.

This merge also removes some ocean-specific variable and dimension names. This because the function lives in the top-level framework so it should work for any component. Instead of providing maxLevelCell in ds, the function needs to be called with a cell_mask argument that should typcially be cell_mask = ds_init.maxLevelCell >= 1 (though it could be another field such as landIceFloatingMaks if appropriate).

All steps that call plot_horiz_field() have been updated to supply the cell_mask argument or to use patches and patch_mask from a previous call.

Checklist

• Developer's Guide has been updated
• Documentation has been built locally and changes look as expected
• Testing comment in the PR documents testing used to verify the changes

[xylar]

Testing

I ran all planar tasks (except 4km and 1km baroclinic channel RPE) on Chrysalis. I included the viz steps for the inertial gravity wave and manufactured solutions tasks. All images look as expected, e.g.:

[xylar]

Further testing

This has sped up the init step of ISOMIP+ tasks at 1 km resolution (in preliminary testing) by more than a factor of 3 from ~32 minutes to ~9 minutes.

[xylar]

Oooh! The speed-up is far better than I thought! I messed up the culling in an unrelated change to this one. After fixing the culling, the init step for ISOMIP+ at 1 km resolution takes less than a minute (even with smoothing over 2 cells)!!!

[cbegeman]

This looks great! I have tested inertial_gravity_wave on chrys with intel, openmpi since that is one of the tests that reuses patches. The viz looks the same as before.

[xylar]

@cbegeman, thanks for your review and testing! This will be great to have in!

[cbegeman]

@xylar This needs to be dtype. Do you want me to open a separate bugfix PR or do you want to combine this with #144?

[xylar]

This should be a separate PR. I'm not sure how soon #144 will be ready to go in. Sorry about that.