-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tridiagonal solver design document #166
Add tridiagonal solver design document #166
Conversation
Note that this design doc includes the Schopf and Loughe (1995) approach for accuracy and stability discussed here: E3SM-Ocean-Discussion#42 |
d519042
to
342bb32
Compare
I have updated this design doc and it is now ready for review. I also opened a draft PR with the implementation (#194). When reviewing the design it might be helpful for you to have a look at one of the unit tests showing how these solvers are used to solve a simple 1D diffusion problem: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwarusz, thank you for this detailed design document. I compiled locally and reviewed the html version, which looks good. Thanks for adding the Thomas and parallel cyclic reduction versions, which will be useful for stability and performance.
This design doc begins with the equation for the general tridiagonal solve, which is the right scope for this part of the project. In a future design doc we can specify the form of those three coefficients and the boundary equations, as I did here for MPAS-Ocean.
Pinging @katsmith133 @vanroekel and @philipwjones, if any of you want to review this design document. |
Seems ok to me. I may be more particular about the interface above this for mixing/diffusion. |
Also looks fine to me. |
Co-authored-by: Mark Petersen <[email protected]>
26a3641
to
30bbafc
Compare
Design document for tridiagonal solve, which will be used for the vertical diffusion in the momentum and tracer equations.
Checklist