-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup of convect_deep.F90 #6900
base: master
Are you sure you want to change the base?
Conversation
ee2564b
to
6efaf6f
Compare
notes: working on testing it. |
The following tests pass on Chrysalis:
The performance of the
|
Thanks, @whannah1. Do these longer tests compare against baselines as well? |
Yes - I'm now creating my own baselines for all tests using a branch that exactly matches the point where each ZM feature branch starts. |
call zm_conv_register | ||
end select | ||
|
||
! Add PBUF variables related to deep convection that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is cutoff here. I think the following couple lines were meant to be reformatted but not removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I meant to delete "that"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This is a continuation of the ZM overhaul and refactoring, which is limited to cosmetic cleanup of the general interface for any implemented deep convection scheme (convect_deep.F90), which is currently limited to Zhang-McFarlane.
[BFB]