Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vercel.com template #576

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

RhysSullivan
Copy link
Contributor

@RhysSullivan RhysSullivan commented Jan 31, 2025

Description

Hey, we're setting up domain connect to make it easier for our users to add domains

When a user is configuring a domain on Vercel, there's 3 fields they need to set:

  1. TXT Verification - The user may need to do this to prove ownership of their domain, optional
  2. CNAME Record - Only used if the user is adding a subdomain
  3. A Record - Only used if the user is adding an apex domain

Here's an example of the types of states the domain config can be in:
image

I'm also working on getting us setup as a DNS Provider with Domain Connect support as well

Thanks for taking a look at the PR, let me know any fixes that need to be made

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

verification: cloudflare.com,99d313170ac2cfc82c10
subdomain: www

Copy link

Linter OK:

Linter result for vercel.com.website.json

Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three commits could be squashed to single one, but that's a minor nit. The template data itself looks good to me.

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pawel-kow pawel-kow added this pull request to the merge queue Jan 31, 2025
Merged via the queue into Domain-Connect:master with commit ce41fc8 Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants