Implement makePrivate and remove non-existent php-cs-fixer config value #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbohlken
force-pushed
the
fix/flags-and-php-cs-fixer-config
branch
from
2da38cf to
a3becf6
Compare
wbohlken
changed the title
vsouz4
reviewed
May 6, 2024
| @@ -39,7 +39,6 @@ | |||
| ], | |||
| 'single_quote' => true, | |||
| 'ternary_operator_spaces' => true, | |||
| 'trailing_comma_in_multiline' => ['elements' => ['arrays']], | |||
There was a problem hiding this comment.
why you say non-existent config value? https://cs.symfony.com/doc/rules/control_structure/trailing_comma_in_multiline.html
vsouz4
reviewed
May 6, 2024
|
|
||
| class ParameterBuilder extends Param | ||
| { | ||
| protected string $docBlockType = ''; | ||
|
|
||
| protected int $flags = 0; |
There was a problem hiding this comment.
this already exists in parent class
vsouz4
reviewed
May 6, 2024
| @@ -55,4 +58,9 @@ public function setDocBlockType(string $docBlockType): self | |||
|
|
|||
| return $this; | |||
| } | |||
|
|
|||
| public function makePrivate(): self { | |||
There was a problem hiding this comment.
also present in parent class
|
Oops, forgot to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fig value