External dependencies #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^--^ ^------------^ | | | +-> Allow to import external dependencies inside service-worker scripts | +-------> Full credit goes to GitHub user @dadleyy. https://github.com/DockYard/ember-service-worker/compare/master...dadleyy:resolve-plugin?expand=1
Resolved merge conflicts package.json package-lock.json service-worker-builder.js
Added some console log statements for debugging.
…worker-builder.js.
…l options. This will require ember-cli 2.13 or above according to https://github.com/babel/ember-cli-babel#compatibility.
* fixed `Build Error (RollupWithDependencies) 'default' is not exported by node_modules/the-answer` by adding the commonjs rollup plugin * fixed `missing paths 'the-answer' is imported by ../../../../../tmp/broccoli-1499Qnek5OYRMuEP/out-908-broccoli_persistent_filter_babel_babel_project/service-worker/index.js, but could not be resolved – treating it as an external dependency` by adding the rollup-plugin-includepaths * fixed the rollup deprecation warning by moving `exports` into the output object
|
@CodingDive I wonder if this is still relevant given the dependency updates that have been made lately? |
|
I'm no longer working with Ember or this project. @MarcoUmpierrez can you confirm that the PR can be closed and is no longer relevant? |
|
Sorry for the delay. Yes, you can close this PR. Thanks. |
|
Thanks for confirming @MarcoUmpierrez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopes to add support for importing external dependencies within the service-worker by bundling dependencies into the sw.js bundle.
At the very beginning (August in the commit history) I implemented the same changes as @dadleyy. #63
Inside the
package.jsonof my Ember app, I was consuming the fork directly from GitHub which worked fine. After recently upgrading ourEmberproject to version 3.5.1, the fix stopped working and I got a lot ofRollupand dependency related issues. The package was tested with 3.5.1 but I do need some guidance on how to test different ember versions and write automated tests for my changes.I also thought I could maybe fix another issue by allowing one to configure babel. As the issues were not related to each other, the changes didn't make it into the final version and I'm saving this issue for another day or someone else.
I wasn't able to run the tests yet due to build errors.
The loader.js addon is missing from your project, please add it to your package.jsonand after adding it, another build errorMissing template processor. If anyone can shed some light on what the best way is to get the tests up and running, please let me know.This is my first non trivial PR so any feedback is greatly appreciated.