Integrated basic info with API #236

defudef · 2020-03-06T05:27:08Z

I can see personal data on my account page
I can see all my addresses from CT
I can see which address is masked for shipment and which one is for billing
I want to see my email address on password change subpage
Refactor MyAccount.vue (using setup instead of data and methods)
Refactor ShippingDetails.vue (using setup instead of data and methods)
Unit tests

defudef · 2020-03-06T09:33:11Z

related #224

packages/commercetools/api-client/src/api/getMe/defaultQuery.ts

packages/core/theme-module/theme/pages/MyAccount.vue

packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue

…my-account-api-integration

CLAassistant · 2020-03-16T08:24:01Z

All committers have signed the CLA.

…my-account-api-integration

packages/commercetools/composables/src/useUser/index.ts

packages/commercetools/composables/src/useUserAddress/index.ts

packages/core/theme-module/theme/pages/MyAccount.vue

packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue

packages/commercetools/composables/src/useUser/index.ts

packages/core/factories/src/useUserAddressFactory.ts

packages/core/interfaces/src/index.ts

…my-account-api-integration

andrzejewsky

Looks ok, but I think it may require an RFC

packages/commercetools/composables/src/useUser/factoryParams.ts

packages/commercetools/composables/src/useUserAddress/factoryParams.ts

packages/commercetools/composables/src/useUserAddress/index.ts

packages/commercetools/composables/tests/useUserAddress/useUserAddress.ts

packages/core/factories/__tests__/useUserAddress.spec.ts

packages/core/factories/src/useUserAddressFactory.ts

packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue

patzick

changes from packages/core/ need to be proposed first as RFC and then after discussion can be further implemented

filrak · 2020-04-09T07:39:59Z

packages/commercetools/composables/src/useUser/factoryParams.ts

-import {UseUserFactoryParams} from '@vue-storefront/factories';
-import {Customer} from '@vue-storefront/commercetools-api/lib//types/GraphQL';
+import { UseUserFactoryParams } from '@vue-storefront/factories';
+import { Customer } from '@vue-storefront/commercetools-api/lib//types/GraphQL';


Suggested change

import { Customer } from '@vue-storefront/commercetools-api/lib//types/GraphQL';

import { Customer } from '@vue-storefront/commercetools-api/lib/types/GraphQL';

filrak · 2020-04-09T07:40:41Z

packages/commercetools/composables/src/useUser/factoryParams.ts

@@ -10,7 +11,9 @@ import {
 } from '@vue-storefront/commercetools-api';
 import useCart from '../useCart';

-export const params: UseUserFactoryParams<Customer, any, any> = {
+export type UpdateUserParams = Customer & { clientSideOnly?: boolean };


can you elaborate more on that?

filrak · 2020-04-09T07:42:43Z

packages/commercetools/composables/src/useUserAddress/factoryParams.ts

+
+export const params: UseUserAddressFactoryParams<Customer, Address, UserAddressType, { [x: string]: any }, UpdateUserParams> = {
+  userComposable,
+  addresses: userComposable.user.value && userComposable.user.value.id ? userComposable.user.value.addresses : [],


user is a computed, readonly property, you can't assign anything to it

You will need to partailly implement #342 for useUser

filrak · 2020-04-09T07:49:08Z

packages/core/factories/src/useUserAddressFactory.ts

+  const loading: Ref<boolean> = ref(false);
+
+  const updateData = async (data: UpdatedUserAddresses<ADDRESS, UPDATE_USER_PARAMS>) => {
+    factoryParams.addresses.length = 0;


filrak · 2020-04-09T07:50:08Z

packages/core/factories/src/useUserAddressFactory.ts

+  SEARCH_PARAMS = { [x: string]: any },
+  UPDATE_USER_PARAMS = any,
+> = {
+  addresses: ADDRESS[];


why you need to explicitly pass those addresses? Shouldn't that be loaded by searchAddresses ?

filrak · 2020-04-09T07:54:37Z

packages/core/factories/src/useUserAddressFactory.ts

+      addAddress,
+      updateAddress,
+      deleteAddress,
+      getBillingAddresses,


this and getShippingAddresses is not a part of a public interface, it could be a getter or computed property or a field within addresses (to be discussed via RFC) but definitely not a public function. It's also not following architectural approach for compostable https://vsf-next-docs.netlify.com/commercetools/composables.html

filrak · 2020-04-09T08:04:42Z

packages/core/theme-module/theme/pages/MyAccount.vue

+      root.$router.push(`/my-account/${title.toLowerCase().replace(' ', '-')}`);
+    };
+
+    const account = computed(() => ({


Why you can't just pass account and avoid additional code while its not doing anything meaningful?

filrak · 2020-04-09T08:07:31Z

packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue

+        ? account.getShippingAddresses().find(shippingAddress => id === shippingAddress.id)
+        : {};
+
+      formType.value = id === null ? 'CREATE' : 'UPDATE';


can you explain why you need that?

filrak · 2020-04-09T08:08:33Z

packages/core/theme-module/theme/pages/MyAccount/ShippingDetails.vue

@@ -1,18 +1,18 @@
 <template>


generally this file is not easily readable, please think about cleaning it up

filrak · 2020-04-09T08:10:00Z

packages/core/factories/src/useUserAddressFactory.ts

@@ -0,0 +1,97 @@
+import { UseUserAddress, UserAddressType, UseUser } from '@vue-storefront/interfaces';


Please work on readability of this code, it's really hard to get some things

Marcin Drwiega added 2 commits March 6, 2020 06:23

interated basic info with API

4c0d657

Removed wrong changes

1935190

defudef changed the title ~~Integrated basic info with API~~ [WIP] Integrated basic info with API Mar 6, 2020

Marcin Drwiega added 2 commits March 6, 2020 08:16

Filter shipping addresses

965654d

refactored shipping details

f347abd

defudef changed the title ~~[WIP] Integrated basic info with API~~ Integrated basic info with API Mar 6, 2020

defudef requested review from andrzejewsky, filrak, patzick and Qrzy March 6, 2020 08:22

defudef self-assigned this Mar 6, 2020

defudef linked an issue Mar 6, 2020 that may be closed by this pull request

I want to see my basic user information after I enter My Account #224

Closed

4 tasks

Qrzy suggested changes Mar 6, 2020

View reviewed changes

Marcin Drwiega added 2 commits March 6, 2020 13:54

changes according to the CR

9c4c3ca

Merge branch 'master' of github.com:DivanteLtd/next into feature/224-…

560d668

…my-account-api-integration

Marcin Drwiega added 5 commits March 18, 2020 08:49

user address factory

779a269

Merge branch 'master' of github.com:DivanteLtd/next into feature/224-…

d685e7c

…my-account-api-integration

working with my account with factories

b9e27dc

Removed unnecesarry tests

f23ce85

integration with API

7095769

filrak suggested changes Mar 24, 2020

View reviewed changes

packages/commercetools/composables/src/useUser/index.ts Outdated Show resolved Hide resolved

packages/commercetools/composables/src/useUserAddress/index.ts Outdated Show resolved Hide resolved

patzick suggested changes Mar 24, 2020

View reviewed changes

Marcin Drwiega added 5 commits March 27, 2020 09:22

refactored + tests

f5cc0cf

Merge branch 'master' of github.com:DivanteLtd/next into feature/224-…

feaa09e

…my-account-api-integration

updated return data

05c67c5

Merge branch 'master' of github.com:DivanteLtd/next into feature/224-…

04428cd

…my-account-api-integration

refactored and updated factories + tests

e8f8c21

defudef requested a review from Qrzy March 31, 2020 06:24

defudef requested review from patzick and filrak March 31, 2020 06:24

defudef linked an issue Mar 31, 2020 that may be closed by this pull request

I want to change My Personal Details #225

Closed

andrzejewsky reviewed Mar 31, 2020

View reviewed changes

packages/commercetools/composables/src/useUser/factoryParams.ts Show resolved Hide resolved

andrzejewsky added the RFC label Mar 31, 2020

Qrzy reviewed Mar 31, 2020

View reviewed changes

patzick suggested changes Apr 1, 2020

View reviewed changes

patzick removed the RFC label Apr 1, 2020

filrak suggested changes Apr 9, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrated basic info with API #236

Integrated basic info with API #236

defudef commented Mar 6, 2020 •

edited

Loading

defudef commented Mar 6, 2020

CLAassistant commented Mar 16, 2020 •

edited

Loading

andrzejewsky left a comment

patzick left a comment

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

filrak Apr 9, 2020

	import { Customer } from '@vue-storefront/commercetools-api/lib//types/GraphQL';
	import { Customer } from '@vue-storefront/commercetools-api/lib/types/GraphQL';

		@@ -0,0 +1,97 @@
		import { UseUserAddress, UserAddressType, UseUser } from '@vue-storefront/interfaces';

Integrated basic info with API #236

Are you sure you want to change the base?

Integrated basic info with API #236

Conversation

defudef commented Mar 6, 2020 • edited Loading

defudef commented Mar 6, 2020

CLAassistant commented Mar 16, 2020 • edited Loading

andrzejewsky left a comment

Choose a reason for hiding this comment

patzick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

defudef commented Mar 6, 2020 •

edited

Loading

CLAassistant commented Mar 16, 2020 •

edited

Loading