improve effect dependencies

DisStreamChat · Aug 19, 2020 · 49f7cd6 · 49f7cd6
1 parent ddd089e
commit 49f7cd6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/components/Chat.js b/src/components/Chat.js
@@ -438,11 +438,13 @@ function App(props) {
 				socket.emit("addme", channel);
 			}
 		}
-	}, [channel, socket]);
+    }, [channel, socket]);
+
+    const ReverseMessageOrder = settings?.ReverseMessageOrder
 
 	useEffect(() => {
 		setTimeout(() => {
-			if (settings?.ReverseMessageOrder) {
+			if (ReverseMessageOrder) {
 				bodyRef.current.scrollTo({
 					top: bodyRef.current.scrollHeight,
 					// behavior: "smooth",
@@ -454,7 +456,7 @@ function App(props) {
 				});
 			}
 		}, 100);
-	}, [settings.ReverseMessageOrder]);
+	}, [ReverseMessageOrder]);
 
 	const handleSearch = useCallback(setSearch, []);