Skip to content

Commit

Permalink
Use micromamba 1.5.10 where conda is needed (pydata#9737)
Browse files Browse the repository at this point in the history
* Use micromamba 1.5.10 together with conda for min-version-policy, since conda.api and libmambapy are not API compatible
* use micromamba 1.5.10-0 for benchmark, since micromamba 2 does not work with `asv`, yet
* pin mamba to <=1.5.10 in benchmark
* revert setting explicit micromamba-version
  • Loading branch information
kmuehlbauer authored Nov 8, 2024
1 parent a57633c commit 61596a7
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks-last-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Set up conda environment
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: '2.0.2-2'
micromamba-version: '1.5.10-0'
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
cache-environment: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Set up conda environment
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: '2.0.2-2'
micromamba-version: '1.5.10-0'
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
cache-environment: true
Expand All @@ -36,7 +36,7 @@ jobs:
create-args: >-
asv
python-build
mamba
mamba<=1.5.10
- name: Run benchmarks
Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/ci-additional.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ concurrency:

env:
FORCE_COLOR: 3
MICROMAMBA_VERSION: "2.0.2-2"

jobs:
detect-ci-trigger:
Expand Down Expand Up @@ -58,7 +57,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
create-args: >-
Expand Down Expand Up @@ -104,7 +102,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
create-args: >-
Expand Down Expand Up @@ -156,7 +153,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
create-args: >-
Expand Down Expand Up @@ -213,7 +209,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
create-args: >-
Expand Down Expand Up @@ -270,7 +265,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ${{env.CONDA_ENV_FILE}}
environment-name: xarray-tests
create-args: >-
Expand Down Expand Up @@ -304,8 +298,7 @@ jobs:
name: Minimum Version Policy
runs-on: "ubuntu-latest"
needs: detect-ci-trigger
# disabled until `conda` is compatible with the new `libmambapy`
if: false && needs.detect-ci-trigger.outputs.triggered == 'false'
if: needs.detect-ci-trigger.outputs.triggered == 'false'
defaults:
run:
shell: bash -l {0}
Expand All @@ -318,13 +311,15 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
# run with micromamba 1.5.10 together with conda
# conda.api is not API compatible with libmambapy
micromamba-version: "1.5.10-0"
environment-name: xarray-tests
create-args: >-
python=3.12
pyyaml
python-dateutil
libmambapy
conda
- name: All-deps minimum versions policy
run: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ concurrency:

env:
FORCE_COLOR: 3
micromamba_version: 2

jobs:
detect-ci-trigger:
Expand Down Expand Up @@ -111,7 +110,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: '2.0.2-2'
environment-file: ${{ env.CONDA_ENV_FILE }}
environment-name: xarray-tests
cache-environment: true
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/hypothesis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
- name: Setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: "2.0.2-2"
environment-file: ci/requirements/environment.yml
environment-name: xarray-tests
create-args: >-
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/upstream-dev-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ concurrency:

env:
FORCE_COLOR: 3
MICROMAMBA_VERSION: "2.0.2-2"

jobs:
detect-ci-trigger:
Expand Down Expand Up @@ -64,7 +63,6 @@ jobs:
- name: Set up conda environment
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ci/requirements/environment.yml
environment-name: xarray-tests
create-args: >-
Expand Down Expand Up @@ -121,7 +119,6 @@ jobs:
- name: Set up conda environment
uses: mamba-org/setup-micromamba@v2
with:
micromamba-version: ${{env.MICROMAMBA_VERSION}}
environment-file: ci/requirements/environment.yml
environment-name: xarray-tests
create-args: >-
Expand Down
4 changes: 2 additions & 2 deletions ci/min_deps_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from collections.abc import Iterator
from datetime import datetime

import libmambapy # type: ignore[import]
import conda.api # type: ignore[import]
import yaml
from dateutil.relativedelta import relativedelta

Expand Down Expand Up @@ -93,7 +93,7 @@ def metadata(entry):

return (major, minor), time

raw_data = libmambapy.SubdirData.query_all(pkg, channels=CHANNELS)
raw_data = conda.api.SubdirData.query_all(pkg, channels=CHANNELS)
data = sorted(metadata(entry) for entry in raw_data if entry.timestamp != 0)

release_dates = {
Expand Down

0 comments on commit 61596a7

Please sign in to comment.