tests, workspace: Add Taproot soft fork status to getblockchaininfo test and VS Code workspace configuration #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `rpc_blockchain.py` functional test to include the Taproot soft fork status in the `getblockchaininfo` RPC call. The Taproot soft fork is defined using the BIP9 activation mechanism with specific start and timeout times. The test verifies that the Taproot soft fork is correctly reported as "defined" and not yet active. Changes include: - Adding Taproot soft fork details to the expected `softforks` field in the `getblockchaininfo` test. - Ensuring the test checks for the correct status, start time, timeout, and activation state of the Taproot soft fork. This update ensures that the `getblockchaininfo` RPC call accurately reflects the status of the Taproot soft fork, which is crucial for testing and validation purposes. Refs #244
This commit adds a new `digibyte.code-workspace` file to the repository. This file is used to configure the Visual Studio Code workspace settings for the DigiByte Core project. The `digibyte.code-workspace` file includes: - Folder settings for the project. - File associations to ensure proper syntax highlighting for various C++ standard library headers. - GitHub Copilot advanced settings to specify project directories. This addition aims to improve the development experience for contributors using Visual Studio Code by providing a pre-configured workspace setup.
gto90
requested review from
SmartArray,
JaredTate,
ycagel and
digicontributer
JaredTate
approved these changes
Dec 16, 2024
|
|
ycagel
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes updates to the
getblockchaininfotest to include the Taproot soft fork status and adds a new Visual Studio Code workspace configuration file to the repository.Changes Made
Commit 0bda8ec:
softforksfield in thegetblockchaininfotest.getblockchaininfoRPC call accurately reflects the status of the Taproot soft fork, which is crucial for testing and validation purposes.Commit 698a43a:
digibyte.code-workspacefile to configure the Visual Studio Code workspace settings for the DigiByte Core project.The
digibyte.code-workspacefile includes the project's folder settings, file associations for proper syntax highlighting, and GitHub Copilot advanced settings.Related Issues
Refs #244
Additional Information
This PR addresses the need for accurate reporting of the Taproot soft fork status in the
getblockchaininfoRPC call and enhances the development environment for contributors using Visual Studio Code.