feat: issue #133 Remove header info from the DigiByte website. #134
Conversation
|
Thank you Dennis, I wasn’t anticipating moving further than the header links, but this works. The Vercel app is very helpful in seeing the proposed changes, which helps me get a glimpse of what the changes will look like before they’re made on the master branch. Looking at the changes, the wiki tab sitting by itself looks out of place, and I think it should be moved to the right of downloads. This PR also addresses changes to the community cards. @ycagel, can you provide further direction and clarification? In the Draft DIP, it says to remove the entire modules for DigiByte Alliance and DGBAT and to relocate them to the DigiByte-Core/digibyte discussion forum. Should the community sub-headers for DigiByte Alliance and DGBAT be left on the website with links that direct viewers to the GitHub discussion? And who is creating the discussions in the DigiByte-Core/digibyte discussion forum? One small change is needed in the DigiByte Developers Card: Remove "DigiByte Developers on Gitter" and replace it with "DigiByte Developers on GitHub Discussions" with a link to the DigiByte-Core/digibyte discussion forum. In the Draft DIP, it says Community: Social Media Remove: Remove Facebook, LinkedIn, Instagram, YouTube, Reddit, Medium. Replace: List X and GitHub. It is not specified in the Draft DIP where to direct the website visitor on GitHub; however, it should be to DigiByte Developers on GitHub Discussions with a link to the DigiByte-Core/digibyte discussion forum. @ycagel, do you think this should be included or left blank since it’s only two social media icons? If it’s left blank, then this card is complete, but if X and GitHub are to be added, then we need to include a Community: Social Media card. The description will also have to be modified and translated across the other language versions of the website: “Follow DigiByte across all primary social media platforms to keep up with the latest DigiByte news and share the posts with your friends to help us make our voices heard all over the world.” Dennis, Community: Meet the Creator of DigiByte Remove: The entire module should be removed. Replace: Nothing. This card is also set to be removed. You didn’t include it, and that’s fine, but it will be added to a future issue to be removed. Just wanted to bring it up since it’s in this section, or we can come back to it later. Same for the Community: Social Media Disclaimer. Page Footer: DigiByte Links Remove: Includes the removal of Blockchain 2035. This is my initial assessment of the proposed changes; I think we need a little more clarification before moving forward with this PR. Dennis thank you as always for volunteering and picking up this task to improve the community website. |
There was a problem hiding this comment.
Thank you so much for volunteering your time to implement these changes. I think this is almost ready to go, except that we need to remove the block regarding the founder of the blockchain and the reference to the Blockchain 2035 book in the footer.
One final change request would be to add a link in the Community section of the page's Wiki block to the Wiki page here: https://github.com/DigiByte-Core/digibyte/wiki/Community
replace it with "DigiByte Developers on GitHub Discussions" with a link to the DigiByte-Core/digibyte discussion forum.
|
I’ve made the updates based on your feedback:
Let me know if you have any further suggestions! |
|
@DennisPitallano thank you as always, |
|
Hi Jose @DGBNOOB , I just synced the latest changes from the main repo to my fork, so Jared's updates should also be reflected on the Vercel app. |
There was a problem hiding this comment.
These are the notes I took to help me review the different commits and files:
7 commits 42538af, 3ec53e3, 8eecd23, 0674c24, ddf00c9, 97ffef9 and e237cc2.
-42538af:
removal dgballiance, dgbat, support
removal dgballiance dgbat
removal of social media card
removal of telegram footer
removal of social media footer
removal of dgballiance and dgbat from digibyte links
lang menu ticker removes pipeline and socials
-3ec53e3:
replaces gitter with GitHub discussions
-8eecd23:
removes meet the creator card
-0674c24:
removes blockchain 2035 link
-ddf00c9:
adds "https://github.com/DigiByte-Core/digibyte/wiki/Community" in the DigiByte Wiki card
-97ffef9
wiki link to header
-e237cc2, 38 files changed, +155 -5,058 lines
Pull Request (PR) 134, Addresses Issue 133 Remove header info from the DigiByte website.
The wiki tab is relocated to the right of downloads at the top, I think this pertains more to website visitors on a laptop. This PR also removes Community Cards: DigiByte Alliance, DigiByte Awareness Team, Social Media, Telegram groups, and replaces Gitter with DigiByte Developers on GitHub Discussions. There is a direct link from Community card “The DigiByte WIKI, by the community, for the community which goes to DigiByte-Core/digibyte/wiki/community”. The “Meet the creator” card is removed. This PR also removes footer info: Telegram channels, DigiByte links to DigiByte Alliance, DigiByte Awareness Team, Blockchain 2035, and social media links.
The first change relocates the Wiki tab to the right of downloads
The next set of changes removes dgballiance, dgbat, wiki, and support
The next set of changes remove dgballiance and dgbat information
The next change replaces Gitter to Github discussions
The next set of changes removes social media and telegram icons and links
The next change is in the Wiki community card where it adds a link to DigiByte-Core/digibyte/wiki/Community.
Removal of telegram footer icons/links
Removal of Social media icons and links
Removal of dgballiance, dgbbat, and 2035 from DigiByte links.
There were also some minor edits to the HTML, everything looks good.
Fantastic job Dennis.
Recommend approval cACK.
issue #133
The social links highlighted in the screenshots have been removed from the website. You can preview and visually review the changes here: https://dg-bio.vercel.app/.