Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bc) Move to Craft 5 #2

Merged
merged 4 commits into from
Aug 13, 2024
Merged

(bc) Move to Craft 5 #2

merged 4 commits into from
Aug 13, 2024

Conversation

f-elix
Copy link
Contributor

@f-elix f-elix commented Jul 25, 2024

  • Adjust composer.json
  • Adjust login button style and position
  • Fix an error message
  • Accept password login when not on the login page. Craft now runs the onBeforeLogin code whenever we need to re-new an elevated session, like when updating a GraphQL schema. I haven't found a way to use the oauth2 API to re-auth since it requires a redirect and we would loose our changes on the page.

Copy link
Member

@nitriques nitriques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe talk about it ?

src/Plugin.php Show resolved Hide resolved
src/Plugin.php Show resolved Hide resolved
src/Plugin.php Show resolved Hide resolved
src/web/assets/login/dist/login.css Outdated Show resolved Hide resolved
Copy link
Member

@nitriques nitriques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@nitriques nitriques changed the title Craft 5 (bc) Move to Craft 5 Aug 13, 2024
@nitriques nitriques merged commit 535f7f5 into DeuxHuitHuit:main Aug 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants