Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate occt #1315

Merged
merged 23 commits into from
Mar 6, 2024
Merged

Integrate occt #1315

merged 23 commits into from
Mar 6, 2024

Conversation

WirajanDASILVA
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit messages follows our guidelines (explicit, in english)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix:
  • New features:
  • Documentation
  • Optimization
  • Other information:

volmdlr/from_occt.py Outdated Show resolved Hide resolved
volmdlr/to_occt.py Outdated Show resolved Hide resolved
@pgibertini
Copy link
Contributor

@WirajanDASILVA as we use OCP as wrapper for OCCT, is it preferable to name module from_ocp to_ocp? What do you think? It can help to avoid confusion, I think.

@WirajanDASILVA WirajanDASILVA merged commit 825a41d into dev Mar 6, 2024
2 checks passed
@WirajanDASILVA WirajanDASILVA deleted the integrate_occt branch March 6, 2024 13:24
@WirajanDASILVA
Copy link
Collaborator Author

WirajanDASILVA commented Mar 6, 2024

@WirajanDASILVA as we use OCP as wrapper for OCCT, is it preferable to name module from_ocp to_ocp? What do you think? It can help to avoid confusion, I think.

Yes, you're right. sorry, I saw your comment only after merging the PR. I do that in the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants