[Move][Checkup] Present RNG Fixes

[frutescens]

What are the changes the user will see?

Present will no longer use global RNG when it is used.
Present will also no longer damage the target for 1 HP before healing the target.
Present's outcomes were shifted by 1 before. This PR fixes that so that the chances of each of the 4 outcomes are accurate to mainline.

Why am I making these changes?

Move Checkups.
#313

What are the changes from a developer perspective?

firstHit variable renamed to isFirstHit
Present-related test removed from Triage since its unnecessary.
powerSeed generated with user.randSeedInt()
Fixed off-by-1 Present RNG

How to test the changes?

Using Present should not affect the events of the next wave.

Screen.Recording.2025-01-23.at.11.52.34.AM.mov

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?

• Are all unit tests still passing? (npm run test:silent)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?

[Tempo-anon]

Probably caused because of toDmgValue making all attacks do a min of 1 damage. Does the 1 tick of damage happen before or after the healing applies?

[innerthunder]

Probably caused because of toDmgValue making all attacks do a min of 1 damage. Does the 1 tick of damage happen before or after the healing applies?

The video seems to show it happens after (which makes sense -- the heal phase is pushed when move power is resolved and before damage is finalized/rounded up)

[innerthunder]

I think a better way to fix it would be to somehow stop MoveEffectPhase.applyMove early if baseDamage <= 0 (Present's base power is -1 internally, and doesn't get overridden if the move ends up healing)

See pigeons comment

[flx-sta]

Heal & Damage at the same time

Screen.Recording.2025-01-23.at.8.42.12.PM.mov

[APPLIED CHANGES FOR TESTING]

I had this

.attr(
        ChangeToStatusCategoryAttr,
        (user, _target, _move) => user.turnData.hitCount === user.turnData.hitsLeft && user.randSeedInt(100) < 20,
        (user, _target, move) => {
          user.turnData.hitCount = 1;
          user.turnData.hitsLeft = 1;
          move.addAttr(new HealAttr(0.25, true, false));
        },
      )

replaced with

.attr(
        ChangeToStatusCategoryAttr,
        (user, _target, _move) => user.turnData.hitCount === user.turnData.hitsLeft && user.randSeedInt(100) < 50, // ⚠️
        (user, _target, move) => {
          user.turnData.hitCount = 1;
          user.turnData.hitsLeft = 1;
          move.addAttr(new HealAttr(0.25, true, false));
        },
      )

[frutescens]

Very confused. I tested it with Singles and Doubles.

I changed

Screen.Recording.2025-01-23.at.9.29.09.PM.mov

[PigeonBar]

I also recommend adding a if (power < 0) {return -1} to the function getBaseDamage().

^{Since the formula for base damage adds 2 damage at the end, it is possible under extreme circumstances for a move with -1 power to deal positive damage.}

[Tempo-anon]

Looks good to me, just some styling comments