Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to UV #2282
Migrate to UV #2282
Changes from 1 commit
a7a6621
7d853ad
915e49e
7528927
c9972e5
73ae578
c7e9d0c
8a69cf2
6d5d0d1
f554139
eefd6f3
1b0e3a6
7ad181a
4022a60
a7d51c9
d847929
315ee6b
1e57ca1
c85d8a3
ea89bad
d32a8a0
32f302a
69c7155
f43426b
c5b78be
f3d3075
f2138a2
bd91e5c
165b0fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing.
When I pushed stuff to the dev AWS account to test it, the image builder threw errors saying there was already a different 0.0.4 of
cdk_stacks/components/add_user.yml
and already a different 0.0.2 ofcdk_stacks/components/instance_connect.yml
, so that's why I've bumped those two despite there being no other changes in those files.I don't really know what a good pattern is for managing this stuff, but given I don't think there's really any downside to bumping a version even if nothing changed, keeping them aligned across AWS accounts seems sensible to me.