Merge pull request #835 from DeluxeAlonso/feature/localization

Feature/localization
DeluxeAlonso · Mar 4, 2024 · 6a87ed1 · 6a87ed1
2 parents 8265a5a + 2a9b766
commit 6a87ed1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/UpcomingMovies/Scenes/Account/CustomListDetail/CustomListDetailViewController.swift b/UpcomingMovies/Scenes/Account/CustomListDetail/CustomListDetailViewController.swift
@@ -15,9 +15,9 @@ class CustomListDetailViewController: UIViewController, Storyboarded {
 
     static var storyboardName = "CustomLists"
 
-    private var headerView: CustomListDetailHeaderView!
+    private var headerView: CustomListDetailHeaderView?
+    private var dataSource: SimpleTableViewDataSource<MovieListCellViewModelProtocol>?
 
-    private var dataSource: SimpleTableViewDataSource<MovieListCellViewModelProtocol>!
     private var displayedCellsIndexPaths = Set<IndexPath>()
 
     /// Used to determinate if the header view is being presented or not.
@@ -88,19 +88,20 @@ class CustomListDetailViewController: UIViewController, Storyboarded {
     }
 
     private func setupTableViewHeader() {
-        headerView = CustomListDetailHeaderView.loadFromNib()
+        let headerView = CustomListDetailHeaderView.loadFromNib()
         headerView.viewModel = viewModel?.buildHeaderViewModel()
 
         headerView.setHeaderOffset(navigationBarHeight)
         headerView.frame = CGRect(x: 0, y: 0, width: headerView.frame.width, height: headerView.frame.height - navigationBarHeight)
 
         tableView.clipsToBounds = false
         tableView.tableHeaderView = headerView
+        self.headerView = headerView
     }
 
     private func reloadTableView() {
         guard let viewModel = viewModel else { return }
-        dataSource = SimpleTableViewDataSource.make(for: viewModel.movieCells)
+        self.dataSource = SimpleTableViewDataSource.make(for: viewModel.movieCells)
         tableView.dataSource = dataSource
         tableView.reloadData()
     }

diff --git a/UpcomingMovies/Scenes/Splash/SplashViewController.swift b/UpcomingMovies/Scenes/Splash/SplashViewController.swift
@@ -8,7 +8,7 @@
 
 import UIKit
 
-class SplashViewController: UIViewController, Storyboarded {
+final class SplashViewController: UIViewController, Storyboarded {
 
     static var storyboardName: String = "Main"