Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init eta checkpoint #283

Merged
merged 3 commits into from
May 14, 2024
Merged

Init eta checkpoint #283

merged 3 commits into from
May 14, 2024

Conversation

amoodie
Copy link
Member

@amoodie amoodie commented May 10, 2024

Rework the integration of these new fields into the checkpointing.

My prev PR (#281) was not thoroughly considered, and therefore was a breaking change, when I didn't mean for it to be. This PR adds handling and a warning when these fields are not found in a checkpoint file, but allows the loading to proceed.

Also fixes the broken documentation, because that checkpoint file was not working.

@amoodie amoodie added the bug Something isn't working label May 10, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.92%. Comparing base (27d0f45) to head (23bc8cf).
Report is 3 commits behind head on develop.

Files Patch % Lines
pyDeltaRCM/init_tools.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #283      +/-   ##
===========================================
+ Coverage    78.88%   78.92%   +0.04%     
===========================================
  Files           12       12              
  Lines         2619     2634      +15     
===========================================
+ Hits          2066     2079      +13     
- Misses         553      555       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amoodie amoodie merged commit 17c2e67 into DeltaRCM:develop May 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant