Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated locales from encounter info #353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emmericp
Copy link
Member

No description provided.

@anon1231823
Copy link
Contributor

anon1231823 commented Jan 13, 2025

Was BRD messed with in SoD? Because I see this for french

[227] = "Grande interrogatrice Gerstahn",

But boss name according to wowhead is Grand Interrogateur Gerstahn
https://www.wowhead.com/classic/fr/npc=9018/grand-interrogateur-gerstahn

For esES,

[227] = "Alta interrogadora Gerstahn",

According to wowhead, Alta Interrogadora Gerstahn
https://www.wowhead.com/classic/es/npc=9018/alta-interrogadora-gerstahn

But I look back at my translation that I put in atlas classic back in 2019 (I ran the dungeons to verify boss names)
Alto Interrogador Gerstahn
https://legacy.curseforge.com/wow/addons/atlas-classicwow/localization/languages/100/phrases#290063

Now granted I haven't done the dungeon since 2019, but I wonder what Blizzard messed with for BRD in SoD and now wowhead isn't even reliable if it overwrote the era translations with new SoD translations. What a mess

@anon1231823
Copy link
Contributor

Are you using the same locale.generated.lua file? I would split it up by patch considering any name changes. You wouldnt want the vanilla TOC file to have the same as WOTLK TOC etc because boss names changed between expansiosn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants