Skip to content

Commit

Permalink
Revert "small tweaks to scanning"
Browse files Browse the repository at this point in the history
This reverts commit 820de13.

This doesn't work: we still need to scan target and mouseover in case we learn the GUID but don't change the target/mouseover.

The vb stuff was just unnecessary, the time between learning the GUID and setting the icon is realistically at worst 5 seconds long, more like 3. Further, if you can get that synced that implies someone else is running DBM and found it. They will have already set the icon and you no longer need to.

The target/mouseover mix-up is already fixed in another commit
  • Loading branch information
emmericp committed Feb 5, 2025
1 parent 85b0ffa commit db0979d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions DBM-Party-Vanilla/Classic/SOD_KarazhanCrypts/DarkRider.lua
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ end

function mod:SPELL_AURA_REMOVED(args)
if args:IsSpell(1220939) then
self.vb.phaseTarget = args.destGUID
phaseTarget = args.destGUID
DBM:Debug("Found real horse GUID: " .. tostring(args.destGUID))
self:ScanLoop(150)
end
Expand All @@ -76,20 +76,20 @@ function mod:ScanMirrorTarget(uId)
end

function mod:ScanPhaseTarget(uId)
if not self.vb.phaseTarget or not UnitGUID(uId) then
if not phaseTarget or not UnitGUID(uId) then
return
end
if UnitGUID(uId) == self.vb.phaseTarget then
if UnitGUID(uId) == phaseTarget then
DBM:Debug("Found real horse uid: " .. tostring(uId))
if GetRaidTargetIndex(uId) ~= 8 then
SetRaidTarget(uId, 8) -- Everyone can (and should in this case) set icons
end
self.vb.phaseTarget = nil
phaseTarget = nil
self:UnscheduleMethod("ScanLoop")
end
end

local scanIds = {"party1target", "party2target", "party3target", "party4target"}
local scanIds = {"target", "mouseover", "party1target", "party2target", "party3target", "party4target"}

function mod:ScanLoop(maxCount)
maxCount = maxCount - 1
Expand Down

0 comments on commit db0979d

Please sign in to comment.