Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Commit

Permalink
Fixed reference to dbup-core and general post split cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
droyad committed Jan 30, 2024
1 parent c9e3d4c commit a0be662
Show file tree
Hide file tree
Showing 5 changed files with 85 additions and 68 deletions.
25 changes: 23 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![GitHub Workflow Status (branch)](https://img.shields.io/github/workflow/status/DbUp/dbup-sqlce/CI/main)](https://github.com/DbUp/dbup-sqlce/actions/workflows/main.yml?query=branch%3Amain)
[![GitHub Workflow Status (branch)](https://img.shields.io/github/actions/workflow/status/DbUp/dbup-sqlce/main.yml?branch=main)](https://github.com/DbUp/dbup-sqlce/actions/workflows/main.yml?query=branch%3Amain)
[![NuGet](https://img.shields.io/nuget/dt/dbup-sqlce.svg)](https://www.nuget.org/packages/dbup-sqlce)
[![NuGet](https://img.shields.io/nuget/v/dbup-sqlce.svg)](https://www.nuget.org/packages/dbup-sqlce)
[![Prerelease](https://img.shields.io/nuget/vpre/dbup-sqlce?color=orange&label=prerelease)](https://www.nuget.org/packages/dbup-sqlce)
Expand All @@ -18,4 +18,25 @@ our [main issue list](https://github.com/DbUp/DbUp/issues).
# Contributing

See the [readme in our main repo](https://github.com/DbUp/DbUp/blob/master/README.md) for how to get started and
contribute.
contribute.

# Known Issues / Quirks

## Semi-colon Delimiter in multi statement scripts

The delimiter in a multi statement script should be on a new-line. I.e:

```sql
ALTER TABLE "MyTable" ADD "foo" int default null
;

ALTER TABLE "MyTable" ADD "bar" int default null
;
```


## Development

For successful unit testing install

- SQL Server Compact 4.0 SP1 https://www.microsoft.com/en-us/download/details.aspx?id=30709
24 changes: 16 additions & 8 deletions src/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ dotnet_style_prefer_conditional_expression_over_return = true:silent
# Naming Conventions #
###############################
# Style Definitions
dotnet_naming_style.pascal_case_style.capitalization = pascal_case
dotnet_naming_style.pascal_case_style.capitalization = pascal_case
# Use PascalCase for constant fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
dotnet_naming_symbols.constant_fields.applicable_kinds = field
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
dotnet_naming_symbols.constant_fields.required_modifiers = const
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
dotnet_naming_symbols.constant_fields.applicable_kinds = field
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
dotnet_naming_symbols.constant_fields.required_modifiers = const
###############################
# C# Coding Conventions #
###############################
Expand All @@ -78,7 +78,7 @@ csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
csharp_style_throw_expression = true:suggestion
csharp_style_conditional_delegate_call = true:suggestion
# Modifier preferences
csharp_preferred_modifier_order = public, private, protected, internal, static, extern, new, virtual, abstract, sealed, override, readonly, unsafe, volatile, async:suggestion
csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
# Expression-level preferences
csharp_prefer_braces = when_multiline:suggestion
csharp_style_deconstructed_variable_declaration = true:suggestion
Expand Down Expand Up @@ -120,4 +120,12 @@ csharp_preserve_single_line_blocks = true
###############################
[*.vb]
# Modifier preferences
visual_basic_preferred_modifier_order = Partial, Default, Private, Protected, Public, Friend, NotOverridable, Overridable, MustOverride, Overloads, Overrides, MustInherit, NotInheritable, Static, Shared, Shadows, ReadOnly, WriteOnly, Dim, Const, WithEvents, Widening, Narrowing, Custom, Async:suggestion
visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion
###############################
# XML and csproj #
###############################
[*.{xml,csproj}]
max_line_length = off
trim_trailing_whitespace = true
insert_final_newline = true
indent_size = 2
48 changes: 24 additions & 24 deletions src/Tests/Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net462</TargetFrameworks>
<AssemblyName>Tests</AssemblyName>
<RootNamespace>DbUp.SqlCe.Tests</RootNamespace>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- <ImplicitUsings>enable</ImplicitUsings> Can't use implict usings with net46 -->
<Nullable>enable</Nullable>
<NoWarn>$(NoWarn);NETSDK1138</NoWarn> <!-- Purposefully leaving an old version of netcoreapp to ensure we have compatibility. This never gets published -->
<LangVersion>latest</LangVersion>
</PropertyGroup>
<PropertyGroup>
<TargetFramework>net462</TargetFramework>
<AssemblyName>Tests</AssemblyName>
<RootNamespace>DbUp.SqlCe.Tests</RootNamespace>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- <ImplicitUsings>enable</ImplicitUsings> Can't use implict usings with net46 -->
<Nullable>enable</Nullable>
<NoWarn>$(NoWarn);NETSDK1138</NoWarn> <!-- Purposefully leaving an old version of netcoreapp to ensure we have compatibility. This never gets published -->
<LangVersion>latest</LangVersion>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\dbup-sqlce\dbup-sqlce.csproj"/>
<PackageReference Include="DbUp.Tests.Common" Version="5.0.37"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
<PackageReference Include="xunit" Version="2.6.6"/>
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\dbup-sqlce\dbup-sqlce.csproj"/>
<PackageReference Include="DbUp.Tests.Common" Version="5.0.37"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
<PackageReference Include="xunit" Version="2.6.6"/>
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<Compile Remove="ApprovalFiles\*.cs"/>
<None Include="ApprovalFiles\*.cs"/>
</ItemGroup>
<ItemGroup>
<Compile Remove="ApprovalFiles\*.cs"/>
<None Include="ApprovalFiles\*.cs"/>
</ItemGroup>

</Project>
4 changes: 0 additions & 4 deletions src/dbup-sqlce/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
using System;
using System.Reflection;
using System.Runtime.InteropServices;

[assembly: AssemblyCompany("DbUp Contributors")]
[assembly: AssemblyProduct("DbUp")]
[assembly: AssemblyCopyright("Copyright © DbUp Contributors 2015")]
[assembly: ComVisible(false)]
[assembly: CLSCompliant(true)]

Expand Down
52 changes: 22 additions & 30 deletions src/dbup-sqlce/dbup-sqlce.csproj
Original file line number Diff line number Diff line change
@@ -1,36 +1,28 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Description>DbUp makes it easy to deploy and upgrade SQL Server databases. This package adds SQL CE Support.</Description>
<Title>DbUp SQL CE Support</Title>
<TargetFrameworks>net462</TargetFrameworks>
<RootNamespace>DbUp.SqlCe</RootNamespace>
<AssemblyOriginatorKeyFile>../dbup.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
<RepositoryUrl>https://github.com/DbUp/dbup-sqlce.git</RepositoryUrl>
<Product>dbup_sqlce</Product>
<PackageId>dbup-sqlce</PackageId>
<PackageIcon>dbup-icon.png</PackageIcon>
</PropertyGroup>
<PropertyGroup>
<Description>DbUp makes it easy to deploy and upgrade SQL Server databases. This package adds SQL CE Support.</Description>
<Title>DbUp SQL CE Support</Title>
<Company>DbUp Contributors</Company>
<Product>DbUp</Product>
<Copyright>Copyright © DbUp Contributors 2015</Copyright>
<TargetFramework>net462</TargetFramework>
<RootNamespace>DbUp.SqlCe</RootNamespace>
<AssemblyOriginatorKeyFile>../dbup.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
<RepositoryUrl>https://github.com/DbUp/dbup-sqlce.git</RepositoryUrl>
<Product>dbup_sqlce</Product>
<PackageId>dbup-sqlce</PackageId>
<PackageIcon>dbup-icon.png</PackageIcon>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="dbup-core" Version="4.5.0"/>
<PackageReference Include="Microsoft.SqlServer.Compact" Version="4.0.8876.1"/>
</ItemGroup>
<ItemGroup>
<PackageReference Include="dbup-core" Version="5.0.37"/>
<PackageReference Include="Microsoft.SqlServer.Compact" Version="4.0.8876.1"/>
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net35'">
<PackageReference Include="Npgsql" Version="2.2.7"/> <!-- Last version that supports .NET 3.5 -->
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' != 'net35'">
<PackageReference Include="Npgsql" Version="3.2.6"/>
</ItemGroup>

<ItemGroup>
<None Visible="false" Include="../dbup-icon.png" Pack="True" PackagePath=""/>
</ItemGroup>
<ItemGroup>
<None Visible="false" Include="../dbup-icon.png" Pack="True" PackagePath=""/>
</ItemGroup>

</Project>

0 comments on commit a0be662

Please sign in to comment.