-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ToStringOut() for series #1150
Conversation
Note: overriding |
Signed-off-by: Dave Skender <[email protected]>
Signed-off-by: Dave Skender <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (4)
tests/indicators/_common/Results/Result.Utilities.ToStringOut.Tests.cs:12
- The test method 'ToStringFixedWidth' is not implemented correctly and needs to be properly implemented.
Assert.Fail("Test not implemented, very wrong syntax.");
tests/indicators/_common/Results/Result.Utilities.ToStringOut.Tests.cs:26
- The test method 'ToStringCSV' is not implemented correctly and needs to be properly implemented.
Assert.Fail("Test not implemented, very wrong syntax.");
tests/indicators/_common/Results/Result.Utilities.ToStringOut.Tests.cs:36
- The test method 'ToStringJson' is not implemented correctly and needs to be properly implemented.
Assert.Fail("Test not implemented, very wrong syntax.");
src/_common/Generics/StringOut.cs:66
- The message should be 'ToStringOut() for JSON output ignores the number format N{decimalsToDisplay}.'
string message = $"ToStringOut() for JSON output ignores number format N{decimalsToDisplay}.";
* Fix the order of date as the first property in the `ToStringOut` method. * Use the `OutType` argument properly in the `ToStringOut` method. * Fix formatting issues for date in the `ToStringOut` method. * Add overloads for `.ToString(int limitQty)` and `.ToString(int startIndex, int endIndex)` methods. * Refactor the `ToStringOut` method for better performance. Add unit tests for `ToStringOut` method * Add unit tests for the new overloads `.ToString(int limitQty)` and `.ToString(int startIndex, int endIndex)`. * Add unit tests for the fixed order of date as the first property. * Add unit tests for the proper use of `OutType` argument. * Add unit tests for the fixed formatting issues for date. * Add unit tests for the refactored `ToStringOut` method performance.
* Fix the order of date as the first property in the `ToStringOut` method * Use the `OutType` argument properly in the `ToStringOut` method * Fix formatting issues for date in the `ToStringOut` method * Add overloads for `.ToString(int limitQty)` and `.ToString(int startIndex, int endIndex)` methods * Refactor the `ToStringOut` method for better performance * Add unit tests for the new overloads and fixed issues in `Result.Utilities.ToStringOut.Tests.cs`
Description
This is a quirky helper utility to convert
ISeries
(quotes and results lists) to a fixed width, CSV, or JSON string. Mostly, I'm thinking this is helpful anyone debugging or wanting to output something to Console for quick visual inspections or general development sharing. Default isOutType.FixedWidth
, since I mostly had Console output and .NET Fiddle use in mind.To do
IResult
to be parameterlessToString()
? Probably not. Maybe we just use.ToStringList()
or.ToStringOut()
OutType
valuesOutType.FixedWidth
, it would ideally be the smallest format possible, keeping in mind that bars could be high frequency date/time values or wider..ToString(int limitQty)
or.ToString(int startIndex, int endIndex)