Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, DavBfr:
I found an issue in UPC-E barcode and fixed it.
One of the cases had a UPC-E input value of "100802" or "01008029".
The barcode content I expect to be displayed is "01008029" , as shown in the 1st picture,
but it displays '01020089' and cannot be read by the barcode scanner , as shown in the 2nd picture.
There are also errors in other input values, such as 107444,100902,100965,555555,1.. etc.
The issue comes from upcaToUpce() , whose RegExp cannot split groups accurately.
Please help to check and merge my fixed version.
Thanks.
OK, Test site : https://www.online-barcode.com/barcode-generator or https://barcodeqrcode.com/upc-e-generator/
![upce_ok](https://private-user-images.githubusercontent.com/12267647/291833235-b935c32b-3a94-44ba-b71d-2bf53b7b65b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTg0MDIsIm5iZiI6MTczOTE1ODEwMiwicGF0aCI6Ii8xMjI2NzY0Ny8yOTE4MzMyMzUtYjkzNWMzMmItM2E5NC00NGJhLWI3MWQtMmJmNTNiN2I2NWIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDAzMjgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM4ZjA2YmIyNmQ3Yjg2YzExNDhlZDBjMmU3OGIyMGU1YWMxNGVjMjI4YmQ4ZjBhYmI3ODdmNmNjZmM2NGIzODcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.852K7gHhppa4x9KPfz_5UAZnNfc9ybOpsUDdqIruD1I)
NG, Test site : https://davbfr.github.io/dart_barcode/#/
![upce_ng](https://private-user-images.githubusercontent.com/12267647/291833307-f325b7e4-05fa-407c-8c66-dc9e550c0ff0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTg0MDIsIm5iZiI6MTczOTE1ODEwMiwicGF0aCI6Ii8xMjI2NzY0Ny8yOTE4MzMzMDctZjMyNWI3ZTQtMDVmYS00MDdjLThjNjYtZGM5ZTU1MGMwZmYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDAzMjgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIzOWFkNmMyYTVhNzNiNGNlOTA4ZWJkNGE3OGUwODgyNDM0NzU2MTBlYTQyZTRmY2EwZDdkNDdlZGExZGE3ZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.oq4zLsdli2n186vs-oVVrOYJLwZ2Lzp7jqCn30aND2Q)