ddtrace/tracer: Memoize the PID #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The os.Getpid() call is visible in profile flamegraphs of busy servers. Memoize it as the PID won't change in the lifetime of a Go process.
ghost
reviewed
May 15, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
Co-Authored-By: fixmie[bot] <fixmie[bot]@users.noreply.github.com>
cgilmour
approved these changes
May 16, 2019
|
Thanks for providing this optimization. Could you take a look at the contribution guidelines, and in the future, consider opening an issue to discuss changes first. @gbbr any action required for the Fixmie error, or is it a CI flake? |
|
Thank you both! This is a good change! |
|
Unsure about CI. It says "Internal error" 😴 |
|
@CAFxX would you mind helping out the |
|
Commented |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
The os.Getpid() call is visible in profile flamegraphs of busy servers. Memoize it as the PID won't change in the lifetime of a Go process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The os.Getpid() call is visible in profile flamegraphs of busy servers.
Memoize it as the PID won't change in the lifetime of a Go process.