[K9VULN-2510] Require explicit v8 flag initialization. Disable eval.
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juli1
approved these changes
Jan 20, 2025
…a stage to type state implementation. Refactor `V8Platform<CfgTest>` and `V8Platform<Initialized>` to be constructed via the same function to ensure parity in tests.
jasonforal
force-pushed
the
jf/K9VULN-2510
branch
from
ef2c64c to
c80d8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
For security reasons, we should disable the JavaScript eval function because it allows arbitrary strings to be executed as JavaScript.
What is your solution?
disallow-code-generation-from-stringsflag (which v8 disables by default).Alternatives considered
What the reviewer should know
globalThis.eval = undefinedbecause the Function object could also be used to dynamically execute the contents of a string (and a reference to that can always be retrieved).