Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky cypress #3

Closed

Conversation

DarshitChanpura
Copy link
Owner

Description

[Describe what this change achieves]

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

stephen-crawford and others added 30 commits March 20, 2024 15:49
* 2.13 release notes

Signed-off-by: Stephen Crawford <[email protected]>

* Fix style and package

Signed-off-by: Stephen Crawford <[email protected]>

* Fix style and package

Signed-off-by: Stephen Crawford <[email protected]>

* Fix link

Signed-off-by: Stephen Crawford <[email protected]>

---------

Signed-off-by: Stephen Crawford <[email protected]>
…1838)

* Add required ml permissions to support new roles

Signed-off-by: Sicheng Song <[email protected]>

* Add ml permissions

Signed-off-by: Sicheng Song <[email protected]>

* Remove internal ml action permissions

Signed-off-by: Sicheng Song <[email protected]>

* Add back internal ml action permissions

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
… default route for the selected tenant (opensearch-project#1820)

* Include saved tenant in login request for basic auth

Signed-off-by: Craig Perkins <[email protected]>

* Add tests for including security_tenant in login

Signed-off-by: Craig Perkins <[email protected]>

* Simplify test

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
…project#1851)

* Add husky to pre-lint any commits, remove unused imports

Signed-off-by: Derek Ho <[email protected]>

* Re-enable the rule after the block

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
…pensearch-project#1872)

* clear session storage on auto-logout & remove unused saml function

Signed-off-by: Shenoy Pratik <[email protected]>

* remote openid unused function

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
* Update copy for tenancy tab

Signed-off-by: Derek Ho <[email protected]>

* Update tests

Signed-off-by: Derek Ho <[email protected]>

* Update more copy

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
…ect#1877)

* Add cluster info to toasts

Signed-off-by: Derek Ho <[email protected]>

* Add URL support

Signed-off-by: Derek Ho <[email protected]>

* Initial work to read/write from url

Signed-off-by: Derek Ho <[email protected]>

* Consume changes from core

Signed-off-by: Derek Ho <[email protected]>

* Lint and remove unused imports

Signed-off-by: Derek Ho <[email protected]>

* Fix edge case and test

Signed-off-by: Derek Ho <[email protected]>

* Refactors tests to accomodate changes to dataSource value consumption from URL

Signed-off-by: Darshit Chanpura <[email protected]>

* Try in headless mode

Signed-off-by: Derek Ho <[email protected]>

* Make closeToast better and revert to admin password for matrix going back to 2.4

Signed-off-by: Derek Ho <[email protected]>

* Try experimental memory management

Signed-off-by: Derek Ho <[email protected]>

* Try to fix closeToast

Signed-off-by: Derek Ho <[email protected]>

* Fix for close toast

Signed-off-by: Derek Ho <[email protected]>

* Find by warning

Signed-off-by: Derek Ho <[email protected]>

* Fix by warning

Signed-off-by: Derek Ho <[email protected]>

* Fix tenancy test from main

Signed-off-by: Derek Ho <[email protected]>

* Fix auth test and be explicit about local datasource

Signed-off-by: Derek Ho <[email protected]>

* Test fixes

Signed-off-by: Derek Ho <[email protected]>

* Fix role flaky test

Signed-off-by: Derek Ho <[email protected]>

* Nit

Signed-off-by: Derek Ho <[email protected]>

* Makes github cypress run headless

Signed-off-by: Darshit Chanpura <[email protected]>

* Enabled experimentalMemoryManagement for chromium based cypress tests

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
…#1839)

* Fixes anonymous auth flow to work with SAML

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds hardcoded credentials for anonymous user

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates basic auth header to be a config constant

Signed-off-by: Darshit Chanpura <[email protected]>

* Removes unneeded usage of anonymous auth header constant

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates logic to display anonymous auth login button

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds test to check whether anonymous auth login button is displayed correctly

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes integrationtests

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds integration tests for anonymous auth login with basic authorization header

Signed-off-by: Darshit Chanpura <[email protected]>

* Generates random password for anonymous user

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes lint errors

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds saml auth header to differentiate saml requests

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes linter errors

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes basic auth tests

Signed-off-by: Darshit Chanpura <[email protected]>

* Removes console loggers

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes lint error

Signed-off-by: Darshit Chanpura <[email protected]>

* Addresses feedback

Signed-off-by: Darshit Chanpura <[email protected]>

* Resolves opensearch-project#1840

Signed-off-by: Darshit Chanpura <[email protected]>

* Replace magic value with constant

Signed-off-by: Darshit Chanpura <[email protected]>

* Renames query param and removes unused variables

Signed-off-by: Darshit Chanpura <[email protected]>

* Uses enum instead of magic constant

Signed-off-by: Darshit Chanpura <[email protected]>

* Extracts template function to a separate util file

Signed-off-by: Darshit Chanpura <[email protected]>

* Renames test

Signed-off-by: Darshit Chanpura <[email protected]>

* Removes unnecessary modifications required to solve this bug

Signed-off-by: Darshit Chanpura <[email protected]>

* Fixes import

Signed-off-by: Darshit Chanpura <[email protected]>

* Removes unused param

Signed-off-by: Darshit Chanpura <[email protected]>

* Removes unused method param

Signed-off-by: Darshit Chanpura <[email protected]>

* Removes incorrect method param

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants