Makes query param required

Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura · Apr 4, 2024 · eb77fe6 · eb77fe6
1 parent 6b3687c
commit eb77fe6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/public/apps/configuration/panels/role-view/role-view.tsx b/public/apps/configuration/panels/role-view/role-view.tsx
@@ -370,7 +370,11 @@ export function RoleView(props: RoleViewProps) {
       color="danger"
       onClick={async () => {
         try {
-          await requestDeleteRoles(props.coreStart.http, [props.roleName]);
+          await requestDeleteRoles(
+            props.coreStart.http,
+            [props.roleName],
+            createDataSourceQuery(dataSource.id)
+          );
           setCrossPageToast(buildUrl(ResourceType.roles), {
             id: 'deleteRole',
             color: 'success',

diff --git a/public/apps/configuration/utils/role-list-utils.tsx b/public/apps/configuration/utils/role-list-utils.tsx
@@ -92,7 +92,7 @@ export function buildSearchFilterOptions(roleList: any[], attrName: string): Arr
 }
 
 // Submit request to delete given roles. No error handling in this function.
-export async function requestDeleteRoles(http: HttpStart, roles: string[], query?: HttpFetchQuery) {
+export async function requestDeleteRoles(http: HttpStart, roles: string[], query: HttpFetchQuery) {
   for (const role of roles) {
     await httpDelete({ http, url: getResourceUrl(API_ENDPOINT_ROLES, role), query });
     await httpDeleteWithIgnores({

diff --git a/public/apps/configuration/utils/role-mapping-utils.tsx b/public/apps/configuration/utils/role-mapping-utils.tsx
@@ -30,11 +30,7 @@ export enum UserType {
   external = 'Backend role',
 }
 
-export async function getRoleMappingData(
-  http: HttpStart,
-  roleName: string,
-  query?: HttpFetchQuery
-) {
+export async function getRoleMappingData(http: HttpStart, roleName: string, query: HttpFetchQuery) {
   return httpGetWithIgnores<RoleMappingDetail>({
     http,
     url: getResourceUrl(API_ENDPOINT_ROLESMAPPING, roleName),
@@ -61,7 +57,7 @@ export async function updateRoleMapping(
   http: HttpStart,
   roleName: string,
   updateObject: RoleMappingDetail,
-  query?: HttpFetchQuery
+  query: HttpFetchQuery
 ) {
   return await httpPost({
     http,