Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : create code-review-section component #120

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat : create code-review-section component #120

merged 1 commit into from
Jul 10, 2024

Conversation

SamTheKorean
Copy link
Contributor

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@SamTheKorean SamTheKorean requested a review from a team as a code owner July 10, 2024 16:09
@SamTheKorean SamTheKorean linked an issue Jul 10, 2024 that may be closed by this pull request
@SamTheKorean
Copy link
Contributor Author

SamTheKorean commented Jul 10, 2024

이 컴포넌트는 다른 컴포넌트들과 매우 유사한 것 같은데 다른 한 분 더 승인 없이 병합해도 될까요?

@sounmind
Copy link
Member

@SamTheKorean 네 그래도 상관 없어 보입니다. 저희가 병합을 위해서 두 개 이상 승인 받기로 했었나요?
하나 이상 받았으니 상관 없을 것 같습니다. 문제가 있으면 그때 또 빠르게 수정하면 되고요~

@SamTheKorean
Copy link
Contributor Author

넵넵! 전에 달레님이 2개 이상 하자고 말씀하셨던걸로 기억합니다!ㅎㅎ

@SamTheKorean SamTheKorean merged commit 5d4a517 into main Jul 10, 2024
@SamTheKorean SamTheKorean deleted the sam/110 branch July 10, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-review section
2 participants