Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: footer, icon-link-list, icon-link #105

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

sounmind
Copy link
Member

@sounmind sounmind commented Jul 4, 2024

  • name changed: footer-icon -> icon-link

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

This was linked to issues Jul 4, 2024
@sounmind sounmind force-pushed the 104-footer-icon-list branch from dcfa579 to 991967f Compare July 8, 2024 03:34
@sounmind sounmind marked this pull request as ready for review July 8, 2024 03:35
@sounmind sounmind requested a review from a team as a code owner July 8, 2024 03:35
- name changed: footer-icon -> icon-link
@sounmind sounmind force-pushed the 104-footer-icon-list branch from 991967f to 700f6e8 Compare July 8, 2024 03:56
components/footer.js Outdated Show resolved Hide resolved
Comment on lines +47 to +50
img {
${width ? `width: ${width};` : ""}
${height ? `height: ${height};` : ""}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

components/icon-link-list.js Outdated Show resolved Hide resolved
@sounmind sounmind force-pushed the 104-footer-icon-list branch from 700f6e8 to 55b4602 Compare July 8, 2024 22:38
@sounmind sounmind requested a review from yolophg July 8, 2024 22:39
@yolophg
Copy link
Contributor

yolophg commented Jul 9, 2024

수고하셨습니다!

@sounmind sounmind merged commit 57e1ee1 into main Jul 9, 2024
@sounmind sounmind deleted the 104-footer-icon-list branch July 9, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footer-icon-list Create Footer Component
2 participants