cmake: build Saigo arm nexe with -O0 to avoid a bug #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slipher
reviewed
Jan 23, 2025
| @@ -231,6 +231,16 @@ else() | |||
| endif() | |||
| endif() | |||
|
|
|||
| if (NACL AND USE_NACL_SAIGO AND SAIGO_ARCH STREQUAL "arm") | |||
| # This should be set for every build type because build type flags | |||
There was a problem hiding this comment.
Please add a link here to the relevant issue
|
LGTM |
illwieckz
force-pushed
the
illwieckz/arm-saigo
branch
from
2a1dd51 to
1650404
Compare
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Unvanquished/Unvanquished#3297:
In the future we may either enable some optimizations from
-O2or enable-O2and disable some specific optimizations to avoid doing a not-optimized-at-all build, but this is enough to make the arm nexe run and then unblock the migration to Saigo.