Set engine command flags #1509
Merged
Set engine command flags #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DolceTriade
reviewed
Jan 21, 2025
| @@ -493,11 +493,13 @@ namespace Cmd { | |||
| return *Cmd::GetEnv(); | |||
| } | |||
|
|
|||
| #ifndef BUILD_ENGINE | |||
There was a problem hiding this comment.
Please leave a comment for this ifdef? Are we basically only allowing this in the dummy app?
There was a problem hiding this comment.
There is a comment explaining this where the constructor is declared in the headers. It is allowed only for gamelogic.
VReaperV
reviewed
Jan 22, 2025
Commands can have flags such as 'BASE' or 'RENDERER' which determine the command listing commands that they appear in. If a command has no flags at all, it does not appear in /listCmds, which seems bad. So I disabled the two-argument StaticCmd constructor without flags in the engine, and defined flags for all the commands using it. Also I changed the set of available flags a bit. Nuked SYSTEM because it is too vague, and added SERVER and CLIENT.
DolceTriade
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @VReaperV discovered while reviewing #1494,
listCmdscan't list a command if it has no flags defined. Fix this by defining flags for all the engine commands and disabling the constructor that doesn't define flags.