Improve contrast of the search placeholder text (JuliaDocs#2235)

Dadidal · Aug 28, 2023 · 8a9f45d · 8a9f45d
1 parent 2c08ddd
commit 8a9f45d
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/assets/html/scss/documenter-dark.scss b/assets/html/scss/documenter-dark.scss
@@ -68,7 +68,7 @@ $documenter-docstring-shadow: none;
 $input-color: $grey-lighter;
 $input-background-color: $body-background-color;
 $input-border-color: $border;
-$input-placeholder-color: rgba($input-color, 0.3);
+$input-placeholder-color: #868c98;
 
 $search-result-link-text-color: #333;
 $search-result-link-text-background-color: #f1f5f9;
@@ -79,8 +79,6 @@ $button-static-color: $grey-lighter;
 $button-static-background-color: $background;
 $button-static-border-color: $border;
 
-$documenter-search-query-text-color: rgba(219, 222, 224, 0.3);
-
 // All secondary themes have to be nested in a theme--$(themename) class. When Documenter
 // switches themes, it applies this class to <html> and then disables the primary
 // stylesheet.

diff --git a/assets/html/scss/documenter/_variables.scss b/assets/html/scss/documenter/_variables.scss
@@ -94,7 +94,7 @@ $documenter-docstring-body-padding: $documenter-docstring-body-padding-v $docume
 $search-result-link-hover: rgba(0, 128, 128, 0.1) !default;
 $search-result-link-text-color: #f1f5f9 !default;
 $search-result-link-text-background-color: #333 !default;
-$search-result-title-text-color: #333 !default; 
+$search-result-title-text-color: #333 !default;
 $search-result-badge-color: whitesmoke !default;
 $search-result-badge-background-color: #33415580 !default;
 $search-modal-scrollbar-background-color: gray !default;
@@ -105,5 +105,4 @@ $search-modal-selected-filter-color: whitesmoke !default;
 $search-modal-selected-filter-background-color: rgba(139, 0, 139, 0.5) !default;
 $search-result-highlight: hsl(48, 100%, 67%) !default;
 
-// Sidebar input box
-$documenter-search-query-text-color: rgba(0, 0, 0, 0.3) !default;
+$input-placeholder-color: #707070 !default;
diff --git a/assets/html/scss/documenter/layout/_sidebar.scss b/assets/html/scss/documenter/layout/_sidebar.scss
@@ -230,7 +230,9 @@
   }
 
   #documenter-search-query {
-    color: $documenter-search-query-text-color;
+    // The search query box is a fake text input, so we re-use the
+    // $input-* styling here.
+    color: $input-placeholder-color;
     width: 0.8 * $documenter-sidebar-width;
     box-shadow: inset 0 1px 2px rgba(10,10,10,0.1);
   }

diff --git a/assets/html/themes/documenter-dark.css b/assets/html/themes/documenter-dark.css
diff --git a/assets/html/themes/documenter-light.css b/assets/html/themes/documenter-light.css
diff --git a/docs/versions.js b/docs/versions.js
@@ -0,0 +1,3 @@
+// This is here just to make the version selector show up when you build Documenter's
+// manual locally when developing / debugging.
+var DOC_VERSIONS = ["build"];