Request-Based listrev #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atterns found in DUNE-DAQ
to more accurately reflect the actual DAQ. Validator publishes a CreateList message to all Generators, which use that information to create a list of integers. Validator sends a RequestList message to one of the Reversers (N). Reverser N sends RequestList messages to each Generator. Generators send IntList message to Reverser N. Reverser sends a ReversedList message containing all pairs of original/reversed lists to Validator. Validator checks list contents.
bieryAtFnal
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
This looks good to me. The six different configurations provide nice coverage for different levels of local-vs-remote connections, IMO.
One very minor question was whether there was a reason for not requesting the original list from the Validator to the Generator. Maybe just convenience...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validator publishes a CreateList message to all Generators, which use
that information to create a list of integers.
Validator sends a RequestList message to one of the Reversers (N).
Reverser N sends RequestList messages to each Generator.
Generators send IntList message to Reverser N.
Reverser sends a ReversedList message containing all pairs of
original/reversed lists to Validator.
Validator checks list contents.