Skip to content

Commit

Permalink
JCF: Issue #129: have a variant, +dev/~dev, determine whether the sta…
Browse files Browse the repository at this point in the history
…ck uses devtools (gdb, cmake, ninja) or not
  • Loading branch information
John Christian Freeman committed Jul 29, 2023
1 parent b39d4df commit b2a32d3
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 3 deletions.
3 changes: 2 additions & 1 deletion scripts/spack/make-release-repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ def generate_daq_umbrella_package(self, repo_path, template_dir):
# now add additional deps:
lines += '\n for build_type in ["Debug", "RelWithDebInfo", "Release"]:'
if self.rtype != "dunedaq":
lines += f'\n depends_on(f"dunedaq@{self.rdict["base_release"]} build_type={{build_type}}", when=f"build_type={{build_type}}")'
lines += f'\n depends_on(f"dunedaq@{self.rdict["base_release"]}+dev build_type={{build_type}}", when=f"+dev build_type={{build_type}}")'
lines += f'\n depends_on(f"dunedaq@{self.rdict["base_release"]}~dev build_type={{build_type}}", when=f"~dev build_type={{build_type}}")'
for idep in self.rdict[ipkg]:
iname = idep["name"]
iver = idep["version"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ class Dunedaq(BundlePackage):
values=('Debug', 'Release', 'RelWithDebInfo'),
multi=True)

depends_on("externals@XRELEASEX", when="@XRELEASEX")
variant('dev', default=False, description='Load in tools used to develop DUNE DAQ packages')

depends_on("externals@XRELEASEX+dev", when="@XRELEASEX+dev")
depends_on("externals@XRELEASEX~dev", when="@XRELEASEX~dev")

def setup_run_environment(self, env):
env.set('DUNE_DAQ_BASE_RELEASE', "XRELEASEX")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ class Externals(BundlePackage):

version("XRELEASEX")

variant('dev', default=False, description='Load in tools used to develop DUNE DAQ packages')

# Generate from release YAML file
depends_on("devtools@XRELEASEX")
depends_on("devtools@XRELEASEX", when="+dev")
depends_on("systems@XRELEASEX", when="~dev")
# Additional dependencies defined in YAML file to be filled below
2 changes: 2 additions & 0 deletions spack-repos/fddaq-repo-template/packages/fddaq/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class Fddaq(BundlePackage):
values=('Debug', 'Release', 'RelWithDebInfo'),
multi=True)

variant('dev', default=False, description='Load in tools used to develop DUNE DAQ packages')

def setup_run_environment(self, env):
env.set('DUNE_DAQ_BASE_RELEASE', "XRELEASEX")

2 changes: 2 additions & 0 deletions spack-repos/nddaq-repo-template/packages/nddaq/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class Nddaq(BundlePackage):
values=('Debug', 'Release', 'RelWithDebInfo'),
multi=True)

variant('dev', default=False, description='Load in tools used to develop DUNE DAQ packages')

def setup_run_environment(self, env):
env.set('DUNE_DAQ_BASE_RELEASE', "XRELEASEX")

0 comments on commit b2a32d3

Please sign in to comment.