Support for nightly code check workflow #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into amogan/clang_format_markdown_summary
…into amogan/daq_release_issue405
jcfreeman2
reviewed
Nov 18, 2024
There was a problem hiding this comment.
This looks good. Two very minor requests:
- If "-m" is passed to dbt-clang-format.sh, at the bottom of the output could there be a statement to the effect of "clang_format_summary_table.md created"?
- Not sure if this technically possible, but if it is, can we reinstate the red font for the "No unit tests written for package X" statement?
|
Just tried to build |
jcfreeman2
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daq-releasePR #411 will add a nightly workflow which runs unit tests and clang formatting checks. In order to report the results of those tests in an easily digestible manner, this PR adds support for markdown output which can be used in GitHub step summaries.dbt-buildwill now usepyteeto write a "no unit tests written" message to stdout as well as the summary log. This allows the nightly code check workflow to parse this information from the unit test summary log, which previously only noted success or failure of unit tests which already exist.dbt-clang-format.shnow has an optional command-line flag,--markdown-summary, which controls whether or not it outputs the clang formatting results to a.mdfile which can be used for the GitHub step summary. I also took this opportunity to improve the argument parsing in that script.The results of the nightly code check workflow, which currently uses this branch of
daq-buildtools, can be seen here.