Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace getcwd with getenv("PWD") to avoid symlink dereferencing #283

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Replace getcwd with getenv("PWD") to avoid symlink dereferencing #283

merged 2 commits into from
Oct 9, 2024

Conversation

alessandrothea
Copy link
Contributor

This change allows executing dbt-build from within simlinked directories

@alessandrothea alessandrothea changed the title Replace getcwd with getenv("PWD") to avoid dereferencing Replace getcwd with getenv("PWD") to avoid symlink dereferencing Oct 9, 2024
@jcfreeman2
Copy link
Collaborator

LGTM. Trying that with daq-buildtools v8.6.1 I get the error

ERROR: [Wed Oct 9 13:13:35 CDT 2024] [/cvmfs/dunedaq.opensciencegrid.org/tools/dbt/v8.6.1/bin/dbt-build:69]: Work area directory "" not found. Exiting...

when I run dbt-build, but using this feature branch, it works.

@jcfreeman2 jcfreeman2 marked this pull request as ready for review October 9, 2024 18:16
@jcfreeman2 jcfreeman2 merged commit 38fb5f0 into develop Oct 9, 2024
@jcfreeman2 jcfreeman2 deleted the thea/cwd branch October 9, 2024 18:17
@alessandrothea alessandrothea mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfreeman2 jcfreeman2 jcfreeman2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandrothea @jcfreeman2