Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCF: since the trace package.py file was modified to set up the trace… #280

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jcfreeman2
Copy link
Collaborator

… environment, no longer need the kluge in dbt-workarea-env.sh which did so

… environment, no longer need the kluge in dbt-workarea-env.sh which did so
@jcfreeman2
Copy link
Collaborator Author

To test this, just check that you can still run tlvls, tshow, etc. after dbt-workarea-env is run in a work area despite this snippet being deleted.

@jcfreeman2 jcfreeman2 requested a review from andrewmogan June 25, 2024 20:09
Copy link
Contributor

@andrewmogan andrewmogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that tlvls and tshow still work after dbt-workarea-env.

@jcfreeman2 jcfreeman2 merged commit 2b1e990 into develop Jun 25, 2024
1 check passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/remove_unneeded_trace_setup branch June 25, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants