Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DUNE_DAQ_RELEASE_SOURCE environment variable to dbt-create #279

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

andrewmogan
Copy link
Contributor

This PR, in combination with DUNE-DAQ/daq-release#381, implements the environment variable DUNE_DAQ_RELEASE_SOURCE, which points to a directory on /cvmfs containing the sourcecode used in the created release. Example usage:

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
git clone https://github.com/DUNE-DAQ/daq-buildtools.git -b amogan/daq_release_issue375
source daq-buildtools/env.sh
dbt-create -n NFDT_DEV_240624_A9 test_new_dbt # Test nightly created using the modified workflows in the linked PR above
cd test_new_dbt && source env.sh
echo $DUNE_DAQ_RELEASE_SOURCE

The last command outputs

/cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFDT_DEV_240624_A9/sourcecode

and an ls in that directory shows all relevant packages.

In the case where the sourcecode directory does not exist, dbt-create will print a warning and DUNE_DAQ_RELEASE_SOURCE will still be set to the non-existent sourcecode area:

WARNING The environment variable DUNE_DAQ_RELEASE_SOURCE has been set to
        /cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFD_DEV_240620_A9/sourcecode,
        but this path does not exist.

@jcfreeman2
Copy link
Collaborator

I think this looks great. One additional idea: how about if the location provided by the environment variable be printed by dbt-info sourcecode? I.e., when you run the command, you see something like this:

dfmodules: develop
fdreadoutlibs: develop

All other packages' sourcecode in /cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFDT_DEV_240624_A9/sourcecode

Copy link
Collaborator

@jcfreeman2 jcfreeman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the dbt-info idea has been nicely implemented.

@jcfreeman2 jcfreeman2 merged commit abeaf38 into develop Jun 25, 2024
@jcfreeman2 jcfreeman2 deleted the amogan/daq_release_issue375 branch June 25, 2024 21:23
@andrewmogan andrewmogan restored the amogan/daq_release_issue375 branch November 15, 2024 19:25
@andrewmogan andrewmogan deleted the amogan/daq_release_issue375 branch November 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants