Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOManager Configuration Object #50

Merged
merged 5 commits into from
Oct 14, 2024
Merged

IOManager Configuration Object #50

merged 5 commits into from
Oct 14, 2024

Conversation

eflumerf
Copy link
Member

Also, update with mroda/logging, add ability to set controller log level

@eflumerf eflumerf mentioned this pull request Oct 14, 2024
Merged
@eflumerf
Copy link
Member Author

Test Nightly: NFDT_DEV_241011_A9
PRs:
DUNE-DAQ/daqsystemtest#130
#50
DUNE-DAQ/iomanager#87
DUNE-DAQ/appfwk#303
DUNE-DAQ/daqconf#521
DUNE-DAQ/listrev#85
DUNE-DAQ/timinglibs#125
DUNE-DAQ/hsilibs#55
DUNE-DAQ/trigger#349
DUNE-DAQ/dfmodules#385
DUNE-DAQ/flxlibs#140
DUNE-DAQ/logging#37
DUNE-DAQ/appmodel#140
DUNE-DAQ/restcmd#25
DUNE-DAQ/drunc#263

This was referenced Oct 14, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@eflumerf eflumerf requested review from mroda88 and plasorak October 14, 2024 14:06
@eflumerf eflumerf self-assigned this Oct 14, 2024
mroda88
mroda88 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nightly, all ok

plasorak
plasorak approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@plasorak plasorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now, but really we should not redefine the port in the gunicorn command line and the service, they should come from the same place.

@eflumerf eflumerf merged commit 63b0268 into develop Oct 14, 2024
1 of 2 checks passed
@eflumerf eflumerf deleted the eflumerf/IOManager_OKS branch October 14, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plasorak plasorak plasorak approved these changes

@mroda88 mroda88 mroda88 approved these changes

Assignees

@eflumerf eflumerf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eflumerf @plasorak @mroda88