New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split whiteSpace into multiple tokens to fix findCaretTokenIndex… #385

Open

JackWang032 wants to merge 1 commit into DTStack:main from JackWang032:fix/newline_suggest

+7,428 −7,319

Collaborator

JackWang032 commented Jan 6, 2025

Fix #376

问题：当SQL存在换行时，一个token会包括多行，findCaretTokenIndex找不到tokenIndex
以下是问题SQL示例：

create table a(id
 <pos>
);

现象为换行处空格后没有补全：

问题原因：
一个token内可能包含多个换行符，导致左边界判断有问题

修复方式：
跟Hive保持一致，将每个空白符拆分到单独的token中去


          fix: split whiteSpace into multiple tokens to fix findCaretTokenIndex…

43f66d9

… may undefined

JackWang032 requested review from Cythia828, liuxy0551 and LuckyFBB

January 6, 2025 11:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet